Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(elasticloadbalancingv2): ALB auth return internal server error #24510

Merged
merged 17 commits into from
May 5, 2023
Merged

fix(elasticloadbalancingv2): ALB auth return internal server error #24510

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2941da6
fix(elbv2): alb auth return internal server error
WinterYukky Mar 8, 2023
98353ee
test(elbv2): add oidc integ test
WinterYukky Mar 8, 2023
4025500
Merge branch 'main' of https://github.com/WinterYukky/aws-cdk into fi…
WinterYukky Apr 1, 2023
c39e749
chore: move to aws-cdk-lib
WinterYukky Apr 1, 2023
e8ed756
Merge branch 'main' of https://github.com/WinterYukky/aws-cdk into fi…
WinterYukky Apr 22, 2023
3fa1ef7
feat(elasticloadbalancingv2): add allowHttpsOutbound props
WinterYukky Apr 23, 2023
9da112f
test(elastiloadbalancingv2): add integ test assertion
WinterYukky Apr 30, 2023
a491c5b
test(elbv2-actions): add integ test assertions
WinterYukky Apr 30, 2023
b0c4074
test(elbv2-actions): Change the domain to a unique
WinterYukky Apr 30, 2023
e5b2899
chore(elbv2): remove bindHook property
WinterYukky Apr 30, 2023
de816e9
Merge branch 'main' into fix/alb-auth-return-internal-server-error
WinterYukky Apr 30, 2023
fee4210
chore: update integ tests
WinterYukky May 1, 2023
46c1605
Merge branch 'main' of https://github.com/WinterYukky/aws-cdk into fi…
WinterYukky May 4, 2023
b46a573
Merge branch 'aws:main' into fix/alb-auth-return-internal-server-error
WinterYukky May 4, 2023
11da833
test(elbv2): update integ
WinterYukky May 5, 2023
04d7b60
Merge branch 'main' into fix/alb-auth-return-internal-server-error
WinterYukky May 5, 2023
e6b5f52
Merge branch 'main' into fix/alb-auth-return-internal-server-error
mergify[bot] May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...s-elasticloadbalancingv2-actions/test/integ.cognito.js.snapshot/integ-cognito.assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
{
"version": "20.0.0",
"version": "30.1.0",
"files": {
"9271c99fa7fd8d6ae26202fec69aaabba91d343b835d6cdc41a76f14fb6462d9": {
"03b4d158d0add3f414e246227b019ec3a9848a1f539b3c90c17f687872402977": {
"source": {
"path": "integ-cognito.template.json",
"packaging": "file"
},
"destinations": {
"current_account-current_region": {
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
"objectKey": "9271c99fa7fd8d6ae26202fec69aaabba91d343b835d6cdc41a76f14fb6462d9.json",
"objectKey": "03b4d158d0add3f414e246227b019ec3a9848a1f539b3c90c17f687872402977.json",
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
}
}
Expand Down
10 changes: 5 additions & 5 deletions ...elasticloadbalancingv2-actions/test/integ.cognito.js.snapshot/integ-cognito.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,11 +432,11 @@
"GroupDescription": "Automatically created Security Group for ELB integcognitoLBFBBBA626",
"SecurityGroupEgress": [
{
"CidrIp": "255.255.255.255/32",
"Description": "Disallow all traffic",
"FromPort": 252,
"IpProtocol": "icmp",
"ToPort": 86
"CidrIp": "0.0.0.0/0",
"Description": "Allow to IdP endpoint",
"FromPort": 443,
"IpProtocol": "tcp",
"ToPort": 443
}
],
"SecurityGroupIngress": [
Expand Down
5 changes: 3 additions & 2 deletions ...k-integ/test/aws-elasticloadbalancingv2-actions/test/integ.cognito.js.snapshot/integ.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
{
"version": "20.0.0",
"version": "30.1.0",
"testCases": {
"integ-test-cognito/DefaultTest": {
"stacks": [
"integ-cognito"
],
"assertionStack": "integ-test-cognito/DefaultTest/DeployAssert"
"assertionStack": "integ-test-cognito/DefaultTest/DeployAssert",
"assertionStackName": "integtestcognitoDefaultTestDeployAssert6F2623C9"
}
}
}
2 changes: 1 addition & 1 deletion ...est/integ.cognito.js.snapshot/integtestcognitoDefaultTestDeployAssert6F2623C9.assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "20.0.0",
"version": "30.1.0",
"files": {
"21fbb51d7b23f6a6c262b46a9caee79d744a3ac019fd45422d988b96d44b2a22": {
"source": {
Expand Down
16 changes: 8 additions & 8 deletions ...nteg/test/aws-elasticloadbalancingv2-actions/test/integ.cognito.js.snapshot/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
{
"version": "20.0.0",
"version": "30.1.0",
"artifacts": {
"Tree": {
"type": "cdk:tree",
"properties": {
"file": "tree.json"
}
},
"integ-cognito.assets": {
"type": "cdk:asset-manifest",
"properties": {
Expand All @@ -23,7 +17,7 @@
"validateOnSynth": false,
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-deploy-role-${AWS::AccountId}-${AWS::Region}",
"cloudFormationExecutionRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-cfn-exec-role-${AWS::AccountId}-${AWS::Region}",
"stackTemplateAssetObjectUrl": "s3://cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}/9271c99fa7fd8d6ae26202fec69aaabba91d343b835d6cdc41a76f14fb6462d9.json",
"stackTemplateAssetObjectUrl": "s3://cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}/03b4d158d0add3f414e246227b019ec3a9848a1f539b3c90c17f687872402977.json",
"requiresBootstrapStackVersion": 6,
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version",
"additionalDependencies": [
Expand Down Expand Up @@ -280,6 +274,12 @@
]
},
"displayName": "integ-test-cognito/DefaultTest/DeployAssert"
},
"Tree": {
"type": "cdk:tree",
"properties": {
"file": "tree.json"
}
}
}
}
94 changes: 64 additions & 30 deletions ...rk-integ/test/aws-elasticloadbalancingv2-actions/test/integ.cognito.js.snapshot/tree.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,6 @@
"id": "App",
"path": "",
"children": {
"Tree": {
"id": "Tree",
"path": "Tree",
"constructInfo": {
"fqn": "constructs.Construct",
"version": "10.1.85"
}
},
"integ-cognito": {
"id": "integ-cognito",
"path": "integ-cognito",
Expand Down Expand Up @@ -91,8 +83,8 @@
"id": "Acl",
"path": "integ-cognito/Stack/PublicSubnet1/Acl",
"constructInfo": {
"fqn": "constructs.Construct",
"version": "10.1.85"
"fqn": "@aws-cdk/core.Resource",
"version": "0.0.0"
}
},
"RouteTable": {
Expand Down Expand Up @@ -258,8 +250,8 @@
"id": "Acl",
"path": "integ-cognito/Stack/PublicSubnet2/Acl",
"constructInfo": {
"fqn": "constructs.Construct",
"version": "10.1.85"
"fqn": "@aws-cdk/core.Resource",
"version": "0.0.0"
}
},
"RouteTable": {
Expand Down Expand Up @@ -425,8 +417,8 @@
"id": "Acl",
"path": "integ-cognito/Stack/PrivateSubnet1/Acl",
"constructInfo": {
"fqn": "constructs.Construct",
"version": "10.1.85"
"fqn": "@aws-cdk/core.Resource",
"version": "0.0.0"
}
},
"RouteTable": {
Expand Down Expand Up @@ -544,8 +536,8 @@
"id": "Acl",
"path": "integ-cognito/Stack/PrivateSubnet2/Acl",
"constructInfo": {
"fqn": "constructs.Construct",
"version": "10.1.85"
"fqn": "@aws-cdk/core.Resource",
"version": "0.0.0"
}
},
"RouteTable": {
Expand Down Expand Up @@ -713,11 +705,11 @@
"groupDescription": "Automatically created Security Group for ELB integcognitoLBFBBBA626",
"securityGroupEgress": [
{
"cidrIp": "255.255.255.255/32",
"description": "Disallow all traffic",
"ipProtocol": "icmp",
"fromPort": 252,
"toPort": 86
"cidrIp": "0.0.0.0/0",
"ipProtocol": "tcp",
"fromPort": 443,
"toPort": 443,
"description": "Allow to OIDC endpoint"
}
],
"securityGroupIngress": [
Expand Down Expand Up @@ -950,14 +942,30 @@
"id": "DNS",
"path": "integ-cognito/DNS",
"constructInfo": {
"fqn": "constructs.Construct",
"version": "10.1.85"
"fqn": "@aws-cdk/core.CfnOutput",
"version": "0.0.0"
}
},
"BootstrapVersion": {
"id": "BootstrapVersion",
"path": "integ-cognito/BootstrapVersion",
"constructInfo": {
"fqn": "@aws-cdk/core.CfnParameter",
"version": "0.0.0"
}
},
"CheckBootstrapVersion": {
"id": "CheckBootstrapVersion",
"path": "integ-cognito/CheckBootstrapVersion",
"constructInfo": {
"fqn": "@aws-cdk/core.CfnRule",
"version": "0.0.0"
}
}
},
"constructInfo": {
"fqn": "constructs.Construct",
"version": "10.1.85"
"fqn": "@aws-cdk/core.Stack",
"version": "0.0.0"
}
},
"integ-test-cognito": {
Expand All @@ -973,15 +981,33 @@
"path": "integ-test-cognito/DefaultTest/Default",
"constructInfo": {
"fqn": "constructs.Construct",
"version": "10.1.85"
"version": "10.1.264"
}
},
"DeployAssert": {
"id": "DeployAssert",
"path": "integ-test-cognito/DefaultTest/DeployAssert",
"children": {
"BootstrapVersion": {
"id": "BootstrapVersion",
"path": "integ-test-cognito/DefaultTest/DeployAssert/BootstrapVersion",
"constructInfo": {
"fqn": "@aws-cdk/core.CfnParameter",
"version": "0.0.0"
}
},
"CheckBootstrapVersion": {
"id": "CheckBootstrapVersion",
"path": "integ-test-cognito/DefaultTest/DeployAssert/CheckBootstrapVersion",
"constructInfo": {
"fqn": "@aws-cdk/core.CfnRule",
"version": "0.0.0"
}
}
},
"constructInfo": {
"fqn": "constructs.Construct",
"version": "10.1.85"
"fqn": "@aws-cdk/core.Stack",
"version": "0.0.0"
}
}
},
Expand All @@ -995,11 +1021,19 @@
"fqn": "@aws-cdk/integ-tests.IntegTest",
"version": "0.0.0"
}
},
"Tree": {
"id": "Tree",
"path": "Tree",
"constructInfo": {
"fqn": "constructs.Construct",
"version": "10.1.264"
}
}
},
"constructInfo": {
"fqn": "constructs.Construct",
"version": "10.1.85"
"fqn": "@aws-cdk/core.App",
"version": "0.0.0"
}
}
}
2 changes: 1 addition & 1 deletion ...sting/framework-integ/test/aws-elasticloadbalancingv2/test/integ.alb2.js.snapshot/cdk.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"version":"20.0.0"}
{"version":"30.1.0"}
19 changes: 19 additions & 0 deletions ...s-cdk/aws-elasticloadbalancingv2/test/integ.alb.oidc.js.snapshot/IntegAlbOidc.assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"version": "30.1.0",
"files": {
"13944846988d75c468396212918043d995ec1813406d85f562acec46d0b9293b": {
"source": {
"path": "IntegAlbOidc.template.json",
"packaging": "file"
},
"destinations": {
"current_account-current_region": {
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
"objectKey": "13944846988d75c468396212918043d995ec1813406d85f562acec46d0b9293b.json",
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
}
}
}
},
"dockerImages": {}
}