Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sfn): stop replacing JsonPath.DISCARD with null #24717

Merged
merged 4 commits into from
Mar 21, 2023
Merged

fix(sfn): stop replacing JsonPath.DISCARD with null #24717

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3918753
fix(sfn): stop replacing JsonPath.DISCARD with `null`
RomainMuller Mar 21, 2023
ab00369
remove unused import
RomainMuller Mar 21, 2023
304f425
fix test
RomainMuller Mar 21, 2023
86e5f40
Merge branch 'main' into rmuller/json-null-sfn
mergify[bot] Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/@aws-cdk/aws-stepfunctions/lib/states/state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Token } from '@aws-cdk/core';
import { IConstruct, Construct, Node } from 'constructs';
import { Condition } from '../condition';
import { FieldUtils, JsonPath } from '../fields';
import { FieldUtils } from '../fields';
import { StateGraph } from '../state-graph';
import { CatchProps, Errors, IChainable, INextable, RetryProps } from '../types';

Expand Down Expand Up @@ -578,7 +578,6 @@ export function renderList<T>(xs: T[], mapFn: (x: T) => any, sortFn?: (a: T, b:
*/
export function renderJsonPath(jsonPath?: string): undefined | null | string {
if (jsonPath === undefined) { return undefined; }
if (jsonPath === JsonPath.DISCARD) { return null; }

if (!Token.isUnresolved(jsonPath) && !jsonPath.startsWith('$')) {
throw new Error(`Expected JSON path to start with '$', got: ${jsonPath}`);
Expand Down