Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ec2): use MachineImage.latestAmazonLinux2 instead of MachineImage.latestAmazonLinux in ec2.BastionHostLinux #25311

Closed
wants to merge 1 commit into from

Conversation

nokok
Copy link

@nokok nokok commented Apr 26, 2023

Closes #25310

We do not know the useful default values, but the purpose is achieved by replacing the API to be used as indicated by the warning.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Apr 26, 2023

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 labels Apr 26, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team April 26, 2023 08:23
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@nokok nokok changed the title fix(ec2) use MachineImage.latestAmazonLinux2 instead of MachineImage.latestAmazonLinux in ec2.BastionHostLinux fix(ec2): use MachineImage.latestAmazonLinux2 instead of MachineImage.latestAmazonLinux in ec2.BastionHostLinux Apr 26, 2023
@nokok nokok force-pushed the fix/ec2-bastion-host-machine-image branch from 16409a6 to 4ac7aa5 Compare April 26, 2023 09:24
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4ac7aa5
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nokok
Copy link
Author

nokok commented Apr 26, 2023

Clarification Request

Tests are currently failing (integration tests). I have fixed the unit test but I need help as I am not sure if it is correct to fix it this way.

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Apr 26, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@nokok nokok closed this Apr 28, 2023
@nokok nokok deleted the fix/ec2-bastion-host-machine-image branch April 28, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ec2: deprecation warning when using ec2.BastionHostLinux with default values.
2 participants