Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): added support for network interfaces on ec2 instances by providing an associatePublicIpAddress property #25441

Merged
merged 21 commits into from May 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
24e6bd6
added associatePublicIpAddress as a property to InstanceProps
colifran May 3, 2023
8d0e507
exposed networkInterfaces property on CfnInstance in Instance constru…
colifran May 3, 2023
a47839d
added unit test for associating a public IP address with primary netw…
colifran May 3, 2023
785429d
added a check for a public subnet if associate public IP address is true
colifran May 3, 2023
d6aa487
updated unit test for associate public IP address to include a public…
colifran May 3, 2023
c4d5497
created integration test to create an EC2 instance with a publis IP a…
colifran May 4, 2023
d07cd6f
updated EC2 instance creation to specify subnetId and securityGroupId…
colifran May 4, 2023
388a6aa
added unit testing for associating a public IP address with an EC2 in…
colifran May 4, 2023
b312aca
wip
colifran May 4, 2023
8a6ea3d
updated README and fixed grammar error
colifran May 4, 2023
0b1ab48
updated network interface configuration logic - added verbiage to the…
colifran May 4, 2023
2d0c6a3
added deleteOnTermination property as true to network interface
colifran May 21, 2023
cc4b9e3
added instance dependency on internet connectivity of subnets
colifran May 22, 2023
b32861c
updated readme to reflect new instance dependency added to code
colifran May 22, 2023
f50f947
updated README with information about what happens when associatePubl…
colifran May 22, 2023
582b1c8
wip
colifran May 22, 2023
2acf13b
added @default for associatePublicIpAddress
colifran May 23, 2023
949f6e4
added dependency on internet connectivity only is associatePublicIpAd…
colifran May 23, 2023
4e49498
updated unit test to check for internet connectivity dependency when …
colifran May 23, 2023
7d088f2
updated integ test and snapshots
colifran May 23, 2023
60d5f90
Merge branch 'main' into colifran/associate-public-ip-address
mergify[bot] May 23, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -0,0 +1 @@
{"version":"31.0.0"}
@@ -0,0 +1,19 @@
{
"version": "31.0.0",
"files": {
"21fbb51d7b23f6a6c262b46a9caee79d744a3ac019fd45422d988b96d44b2a22": {
"source": {
"path": "instancetestDefaultTestDeployAssert5516EAF1.template.json",
"packaging": "file"
},
"destinations": {
"current_account-current_region": {
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
"objectKey": "21fbb51d7b23f6a6c262b46a9caee79d744a3ac019fd45422d988b96d44b2a22.json",
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
}
}
}
},
"dockerImages": {}
}
@@ -0,0 +1,36 @@
{
"Parameters": {
"BootstrapVersion": {
"Type": "AWS::SSM::Parameter::Value<String>",
"Default": "/cdk-bootstrap/hnb659fds/version",
"Description": "Version of the CDK Bootstrap resources in this environment, automatically retrieved from SSM Parameter Store. [cdk:skip]"
}
},
"Rules": {
"CheckBootstrapVersion": {
"Assertions": [
{
"Assert": {
"Fn::Not": [
{
"Fn::Contains": [
[
"1",
"2",
"3",
"4",
"5"
],
{
"Ref": "BootstrapVersion"
}
]
}
]
},
"AssertDescription": "CDK bootstrap stack version 6 required. Please run 'cdk bootstrap' with a recent version of the CDK CLI."
}
]
}
}
}
@@ -0,0 +1,19 @@
{
"version": "31.0.0",
"files": {
"488d9cf540c6790fc09af871e06438e043f47d03101ef192131f1dafbbb434cb": {
"source": {
"path": "integ-ec2-instance.template.json",
"packaging": "file"
},
"destinations": {
"current_account-current_region": {
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
"objectKey": "488d9cf540c6790fc09af871e06438e043f47d03101ef192131f1dafbbb434cb.json",
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
}
}
}
},
"dockerImages": {}
}