Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add note about stored context when looking up VPC AZs #25446

Merged
merged 2 commits into from
May 5, 2023
Merged

docs: add note about stored context when looking up VPC AZs #25446

merged 2 commits into from
May 5, 2023

Conversation

peterwoodworth
Copy link
Contributor

@peterwoodworth peterwoodworth commented May 4, 2023 •
edited
Loading

Adding this note to be explicitly clear

Closes #16250

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 4, 2023

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels May 4, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team May 4, 2023 22:16
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 4, 2023
@peterwoodworth peterwoodworth mentioned this pull request May 4, 2023
Closed
@peterwoodworth
Copy link
Contributor Author

Linter failed with Error: Not Found 🤔

@peterwoodworth peterwoodworth changed the title docs: add note about stored context when looking up vpc azs docs: add note about stored context when looking up VPC AZs May 4, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 4, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 296fd9d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 5, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c3744ae into main May 5, 2023
5 checks passed
@mergify mergify bot deleted the peterwoodworth/vpcContextDocs branch May 5, 2023 11:08
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corymhall corymhall corymhall approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws_cdk.aws_ec2): Ability to get stable list of n subnets
3 participants
@peterwoodworth @aws-cdk-automation @corymhall