Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(app-staging-synthesizer): remove unnecessary documentation #25896

Merged
merged 2 commits into from
Jun 8, 2023
Merged

chore(app-staging-synthesizer): remove unnecessary documentation #25896

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d3f09b
chore(app-staging-synthesizer): remove unnecessary documentation
kaizencc Jun 7, 2023
7e10ae0
Merge branch 'main' into kaizencc-patch-8
mergify[bot] Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/@aws-cdk/app-staging-synthesizer-alpha/lib/default-staging-stack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,19 +150,13 @@ export class DefaultStagingStack extends Stack implements IStagingResources {
* Default asset publishing role name for file (S3) assets.
*/
private get fileRoleName() {
// This role name can be a maximum of 64 letters. The reason why
// we slice the appId and not the entire name is because this.region
// can be a token and we don't want to accidentally cut it off.
return `cdk-${this.appId}-file-role-${this.region}`;
}

/**
* Default asset publishing role name for docker (ECR) assets.
*/
private get imageRoleName() {
// This role name can be a maximum of 64 letters. The reason why
// we slice the appId and not the entire name is because this.region
// can be a token and we don't want to accidentally cut it off.
return `cdk-${this.appId}-image-role-${this.region}`;
}

Expand Down