fix(cdk): performance improvements by utilizing Promise.all

[sanjaiyan-dev]

This pull request aims to optimize performance by leveraging the Promise.all method to execute functions concurrently. By utilizing this approach, we can achieve improved efficiency and potentially reduce the overall execution time of the codebase.

Changes Made

• Introduced the use of Promise.all to concurrently execute multiple functions.
• Replaced sequential function calls with parallel execution using Promise.all.
• Utilized await to handle the resolved values of the promises returned by Promise.all.
• Ensured proper error handling and error propagation within the promises.

Benefits

• Enhances performance by executing functions concurrently, leveraging the available resources efficiently.
• Reduces the overall execution time by avoiding unnecessary sequential execution.
• Improves code readability by eliminating complex asynchronous control flow patterns.
• Maintains error handling capabilities and propagates errors appropriately within the promises.

Please review these changes and let me know if any further adjustments or enhancements are required.

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[sanjaiyan-dev]

🤔

[mrgrain]

@aws-cdk/cdk-build-tools: lib/compile.ts(14,48): error TS2345: Argument of type '(javascriptFile: string) => Promise<void>' is not assignable to parameter of type '(value: unknown, index: number, array: unknown[]) => Promise<void>'.
@aws-cdk/cdk-build-tools:   Types of parameters 'javascriptFile' and 'value' are incompatible.
@aws-cdk/cdk-build-tools:     Type 'unknown' is not assignable to type 'string'.
@aws-cdk/cdk-build-tools: �[2K�[1G�[31merror�[39m Command failed with exit code 1.
@aws-cdk/cdk-build-tools: �[2K�[1G�[34minfo�[39m Visit �[1mhttps://yarnpkg.com/en/docs/cli/run�[22m for documentation about this command.

[mrgrain]

@sanjaiyan-dev Very cool thanks for that! Unfortunately the change seems to make the build fail.

Are you invested enough to look into this?
Also, did you run any benchmarks on how much this improves the performance?

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: d0955d6
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mrgrain]

@sanjaiyan-dev I need a passing build and I can run the cli integ tests for you. I've exempted the other things.

[sanjaiyan-dev]

@sanjaiyan-dev Very cool thanks for that! Unfortunately the change seems to make the build fail.

Are you invested enough to look into this?
Also, did you run any benchmarks on how much this improves the performance?

I'm sorry to hear that the recent change caused the build to fail. I apologize for any inconvenience it may have caused. I'm invested in resolving the issue and will look into it immediately to identify the cause and find a solution. 🙌

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/25945/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

[mrgrain]

I'm sorry to hear that the recent change caused the build to fail. I apologize for any inconvenience it may have caused. I'm invested in resolving the issue and will look into it immediately to identify the cause and find a solution. 🙌

No worries. Just open a new PR when you are ready.