Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): prevent the error when the condition is split into groups of 10 and 1 in Fn.conditionAnd() #25999

Merged
merged 2 commits into from Jun 28, 2023
Merged

fix(core): prevent the error when the condition is split into groups of 10 and 1 in Fn.conditionAnd() #25999

merged 2 commits into from Jun 28, 2023

Conversation

wafuwafu13
Copy link
Contributor

Closes #25696 (comment)

Same solution as #25708

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 15, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team June 15, 2023 20:37
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jun 15, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@wafuwafu13
Copy link
Contributor Author

Exemption Request

packages/aws-cdk-lib/core/test/condition.test.ts exists

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jun 15, 2023
corymhall
corymhall previously approved these changes Jun 27, 2023
View reviewed changes
@corymhall corymhall added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jun 27, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 27, 2023 11:25

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed corymhall’s stale review June 28, 2023 16:34

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3111aa8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ee3d41e into aws:main Jun 28, 2023
7 checks passed
ahmetsoykan pushed a commit to ahmetsoykan/aws-cdk that referenced this pull request Jun 28, 2023
@wafuwafu13 @ahmetsoykan
fix(core): prevent the error when the condition is split into groups …
a15fc10 
…of 10 and 1 in `Fn.conditionAnd()` (aws#25999)

Closes aws#25696 (comment)

Same solution as aws#25708

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
ahmetsoykan added a commit to ahmetsoykan/aws-cdk that referenced this pull request Jun 28, 2023
@ahmetsoykan
Revert "fix(core): prevent the error when the condition is split into…
346f49b 
… groups of 10 and 1 in `Fn.conditionAnd()` (aws#25999)"

This reverts commit a15fc10.
lukey-aleios pushed a commit to lukey-aleios/aws-cdk that referenced this pull request Jun 30, 2023
@wafuwafu13 @lukey-aleios
fix(core): prevent the error when the condition is split into groups …
efc1b34 
…of 10 and 1 in `Fn.conditionAnd()` (aws#25999)

Closes aws#25696 (comment)

Same solution as aws#25708

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
lukey-aleios pushed a commit to lukey-aleios/aws-cdk that referenced this pull request Jun 30, 2023
@wafuwafu13 @lukey-aleios
fix(core): prevent the error when the condition is split into groups …
52f2d4a 
…of 10 and 1 in `Fn.conditionAnd()` (aws#25999)

Closes aws#25696 (comment)

Same solution as aws#25708

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corymhall corymhall corymhall approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fn.conditionOr generates invalid CFN snippet
3 participants
@wafuwafu13 @aws-cdk-automation @corymhall