Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions-tasks): add sagemaker:AddTags policy for CreateTransformJob policy statements #26029

Closed
wants to merge 2 commits into from

Conversation

l3ku
Copy link

@l3ku l3ku commented Jun 17, 2023

This PR adds the missing sagemaker:AddTags policy for the state machine execution role when trying to create a SageMaker batch transform job using the RUN_JOB integration type, since the step functions service by default adds tags to the batch transform job in that scenario. More details about the problem in #26012.

I could not find any place to modify any existing tests that would test the content of the state machine execution role policies when adding a batch transform job to the state machine, feel free to point me to the correct location in the codebase!

Closes #26012


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team June 17, 2023 14:00
@github-actions github-actions bot added bug This issue is a bug. p2 labels Jun 17, 2023
@gitpod-io
Copy link

gitpod-io bot commented Jun 17, 2023

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jun 17, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@l3ku l3ku force-pushed the main branch 2 times, most recently from 41eab16 to c3bddca Compare June 17, 2023 14:03
@l3ku l3ku changed the title Add sagemaker:AddTags policy for CreateTransformJob policy statements fix(aws-stepfunctions-tasks): add sagemaker:AddTags policy for CreateTransformJob policy statements Jun 17, 2023
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Jun 17, 2023
@l3ku l3ku changed the title fix(aws-stepfunctions-tasks): add sagemaker:AddTags policy for CreateTransformJob policy statements fix(stepfunctions-tasks): add sagemaker:AddTags policy for CreateTransformJob policy statements Jun 17, 2023
@l3ku
Copy link
Author

l3ku commented Jun 18, 2023

Clarification Request: I could not find any place to modify any existing integration tests that would use the SageMakerCreateTransformJob as part of the state machine definition, please let me know if integration tests need to be added for this.

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Jun 18, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e27cece
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 18, 2023
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Jul 17, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run
Projects
None yet
2 participants