Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli-lib): bundle bootstrap template #26229

Merged
merged 2 commits into from
Jul 4, 2023
Merged

fix(cli-lib): bundle bootstrap template #26229

merged 2 commits into from
Jul 4, 2023

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Jul 4, 2023

Closes #26224

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 4, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team July 4, 2023 16:20
@github-actions github-actions bot added bug This issue is a bug. p2 labels Jul 4, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 4, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mrgrain mrgrain added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jul 4, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 4, 2023 16:29

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3ef2244
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 4, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 41cb288 into main Jul 4, 2023
11 checks passed
@mergify mergify bot deleted the mrgrain/fix/cli-lib-bootstrap branch July 4, 2023 17:44
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(cli-lib): cannot load the default bootstrap template
3 participants
@mrgrain @aws-cdk-automation @rix0rrr