Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloudwatch): allow configuring period on SingleValueWidget #26260

Merged
merged 5 commits into from
Jul 7, 2023
Merged

feat(cloudwatch): allow configuring period on SingleValueWidget #26260

merged 5 commits into from
Jul 7, 2023

Conversation

humanzz
Copy link
Contributor

@humanzz humanzz commented Jul 6, 2023 •
edited

  • expose a period prop on SingleValueWidgetProps
  • use the period prop when rendering SingleValueWidget

Closes #26259.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 6, 2023

@github-actions github-actions bot added the valued-contributor [Pilot] contributed between 6-12 PRs to the CDK label Jul 6, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 6, 2023 13:59
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 labels Jul 6, 2023
@humanzz humanzz changed the title allow configuring period on SingleValueWidget feat(cloudwatch): allow configuring period on SingleValueWidget Jul 6, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review July 6, 2023 14:11

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 6, 2023
@colifran colifran self-assigned this Jul 7, 2023
colifran
colifran previously approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@colifran colifran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@humanzz this looks great! Thank you for your contribution.

@humanzz
Copy link
Contributor Author

humanzz commented Jul 7, 2023

@colifran Great! I just noticed that the merge from main failed. Am suspecting some transient build failure!

@colifran
Copy link
Contributor

colifran commented Jul 7, 2023

@humanzz I'm suspecting the same thing. You could try pushing an empty commit to re-run the build.

@mergify mergify bot dismissed colifran’s stale review July 7, 2023 19:52

Pull request has been modified.

@colifran colifran removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 7, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9952572
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c8edc87 into aws:main Jul 7, 2023
9 checks passed
@humanzz humanzz deleted the svw-period branch July 7, 2023 21:17
tmokmss pushed a commit to tmokmss/aws-cdk that referenced this pull request Jul 9, 2023
@humanzz @tmokmss
feat(cloudwatch): allow configuring period on SingleValueWidget (aws#…
c357350 
…26260)

- expose a period prop on `SingleValueWidgetProps`
- use the period prop when rendering `SingleValueWidget`

Closes aws#26259.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@humanzz @bmoffatt
feat(cloudwatch): allow configuring period on SingleValueWidget (aws#…
12ad867 
…26260)

- expose a period prop on `SingleValueWidgetProps`
- use the period prop when rendering `SingleValueWidget`

Closes aws#26259.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colifran colifran colifran approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

@colifran colifran

Labels
feature-request A feature should be added or improved. p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cloudwatch: allow configuring period on SingleValueWidget
3 participants
@humanzz @colifran @aws-cdk-automation