Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(neptune-alpha): cannot set custom retention period for multiple log exports #26293

Closed
wants to merge 3 commits into from

Conversation

kscjosep
Copy link

@kscjosep kscjosep commented Jul 7, 2023

Fixed an issue with string interpolation of the LogType object in aws-neptune-alpha. Since the entire object was being interpolated instead of the string value (logType.value), the result was [object object]. This was preventing users from setting a custom retention period for multiple log exports due to naming construct conflicts, as each log export was named [object object]LogRetention.

Error message when assigning cloudwatchLogsExports: [new LogType('audit'), new LogType('slowquery')], to a Neptune DatabaseCluster in CDK:

Error: There is already a Construct with name '[object Object]LogRetention' in DatabaseCluster ...

Updated to access the logType string value (logType.value) to fix this issue.

Closes #26295


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 7, 2023

@github-actions github-actions bot added the p2 label Jul 7, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 7, 2023 22:35
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jul 7, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@kscjosep kscjosep changed the title fix(aws-neptune-alpha): object string interpolation error fix(neptune-alpha): object string interpolation error Jul 7, 2023
@github-actions github-actions bot added the bug This issue is a bug. label Jul 8, 2023
@kscjosep kscjosep changed the title fix(neptune-alpha): object string interpolation error fix(neptune-alpha): cannot set custom retention period for multiple log exports Jul 8, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d3b4bbb
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Aug 5, 2023
@kaizencc kaizencc reopened this Aug 11, 2023
@github-actions github-actions bot added effort/small Small work item – less than a day of effort p1 and removed p2 labels Aug 11, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(neptune-alpha): Unable to set custom retention period for multiple CloudWatch log exports
3 participants