Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cdk-lib): re-enable skipped tests #26367

Merged
merged 5 commits into from
Jul 16, 2023

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Jul 14, 2023

Some tests were previously skipped. Un-skip them and put a linter rule in place that prevents this.

Closes #25137


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain changed the title chore(cdk-lib): enabled skipped tests chore(cdk-lib): re-enable skipped tests Jul 14, 2023
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Jul 14, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 14, 2023 13:21
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 14, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b5e4491
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 16, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 99fd917 into main Jul 16, 2023
6 checks passed
@mergify mergify bot deleted the mrgrain/chore/fix-unstable-node-js-tests branch July 16, 2023 13:58
colifran pushed a commit that referenced this pull request Jul 17, 2023
Some tests were previously skipped. Un-skip them and put a linter rule in place that prevents this.

Closes #25137 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
Some tests were previously skipped. Un-skip them and put a linter rule in place that prevents this.

Closes aws#25137 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some of the tests are being skipped in the repository
3 participants