Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lambda): update default node runtime for all partitions #26475

Merged
merged 6 commits into from
Aug 4, 2023

Conversation

lpizzinidev
Copy link
Contributor

Node18 is the default runtime environment for lambdas in the default, China, and GovCloud regions.

This fix updates the runtime default versions for constructs that were still using older versions, in particular:

  • LogRetention
  • AwsCustomResource
  • CustomResourceProvider

Also, it updates the DefaultCrNodeVersionMap in the fact tables to reflect the updated values.

Closes #26461.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Jul 23, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 23, 2023 10:06
@github-actions github-actions bot added bug This issue is a bug. p1 labels Jul 23, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@lpizzinidev
Copy link
Contributor Author

Clarification Request.
Is an integration test required in this case?

@aws-cdk-automation aws-cdk-automation added pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run pr/needs-maintainer-review This PR needs a review from a Core Team Member labels Jul 24, 2023
@kaizencc kaizencc added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run labels Jul 25, 2023
kaizencc
kaizencc previously approved these changes Jul 25, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 25, 2023 16:58

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 25, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 25, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@kaizencc kaizencc added the pr/do-not-merge This PR should not be merged at this time. label Jul 25, 2023
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

received a tip about a custom resource potentially not working with node18. so i'm gonna run it to check

@kaizencc
Copy link
Contributor

Hmm I got this error on delete when running log-retention integ. Might not be ready for node18 yet but I haven't had time to dive in and figure out whats necessary to fix

{
    "errorType": "Runtime.ImportModuleError",
    "errorMessage": "Error: Cannot find module 'aws-sdk'\nRequire stack:\n- /var/task/index.js\n- /var/runtime/index.mjs",
    "stack": [
        "Runtime.ImportModuleError: Error: Cannot find module 'aws-sdk'",
        "Require stack:",
        "- /var/task/index.js",
        "- /var/runtime/index.mjs",
        "    at _loadUserApp (file:///var/runtime/index.mjs:997:17)",
        "    at async UserFunction.js.module.exports.load (file:///var/runtime/index.mjs:1029:21)",
        "    at async start (file:///var/runtime/index.mjs:1192:23)",
        "    at async file:///var/runtime/index.mjs:1198:1"
    ]
}
111

@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 2, 2023

I am surprised that this would still be necessary. I thought we just did a big campaign upgrading aws-sdkv2 -> v3 everywhere, which should have included this.

@mergify mergify bot dismissed kaizencc’s stale review August 3, 2023 08:32

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 3, 2023
@rix0rrr rix0rrr changed the title fix(lambda): updated default node runtime for lambdas in default, China, and Gov regions chore(lambda): update default node runtime for all partitions Aug 4, 2023
@rix0rrr rix0rrr removed the pr/do-not-merge This PR should not be merged at this time. label Aug 4, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5ce67bf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 4, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a35fcc5 into aws:main Aug 4, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p1 pr/needs-maintainer-review This PR needs a review from a Core Team Member pr-linter/exempt-integ-test The PR linter will not require integ test changes star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(lambda): (CDK lambdas still using node16)
5 participants