Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3): improve BucketProps types for public access control #26555

Conversation

ChenKuanSun
Copy link

In this PR, we have enhanced the type definitions of BucketProps to provide safer and more explicit access control for S3 buckets. We've introduced two new types: BucketPropsPublicReadAccess and BucketPropsPrivateAccess, extending from the BucketPropsBase.

BucketPropsPublicReadAccess is intended for use cases where the S3 bucket needs to be publicly readable. It enforces the inclusion of a blockPublicAccess configuration whenever publicReadAccess is set to true, helping ensure that only necessary permissions are exposed.

BucketPropsPrivateAccess, on the other hand, is intended for cases where public read access is not required for the S3 bucket. It allows publicReadAccess to be false or undefined, and provides an optional blockPublicAccess configuration for additional control over public access.

Related #25983

Screenshot:
Screenshot 2023-07-28 at 08 27 34

Screen.Recording.2023-07-28.at.08.27.05.mov

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jul 28, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 28, 2023 15:28
@github-actions github-actions bot added the p2 label Jul 28, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2d99d4e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants