Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix spec update does not add new modules #27215

Merged
merged 1 commit into from
Sep 20, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions .github/workflows/spec-update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ jobs:
contents: read
runs-on: ubuntu-latest
steps:

- name: Check Out
uses: actions/checkout@v4

Expand All @@ -35,8 +34,14 @@ jobs:

# This will ensure the current lockfile is up-to-date with the dependency specifications
- name: Install latest version & update lockfile
run: |-
yarn upgrade @aws-cdk/aws-service-spec @aws-cdk/service-spec-types
run: yarn upgrade @aws-cdk/aws-service-spec @aws-cdk/service-spec-types

# Build @aws-cdk/spec2cdk and run L1 gen script to generate base files for new modules
- name: Build @aws-cdk/spec2cdk
run: lerna run build --stream --no-progress --skip-nx-cache --scope @aws-cdk/spec2cdk
- name: Generate L1s
working-directory: packages/aws-cdk-lib
run: yarn gen

# Next, create and upload the changes as a patch file. This will later be downloaded to create a pull request
# Creating a pull request requires write permissions and it's best to keep write privileges isolated.
Expand Down Expand Up @@ -80,9 +85,9 @@ jobs:
feat: update AWS Service Spec
AWS Service Spec packages to latest versions.
# Pull Request details
title: 'feat: update AWS Service Spec'
title: "feat: update AWS Service Spec"
body: |-
AWS Service Spec packages to latest versions.
AWS Service Spec packages to latest versions.
labels: contribution/core,dependencies,auto-approve,pr-linter/exempt-integ-test,pr-linter/exempt-readme,pr-linter/exempt-test
team-reviewers: aws-cdk-team
# Github prevents further Github actions to be run if the default Github token is used.
Expand Down
Loading