Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-stepfunctions): add support for AmazonSageMaker APIs #2808

Merged
merged 11 commits into from
Jun 12, 2019
Merged

feat(aws-stepfunctions): add support for AmazonSageMaker APIs #2808

merged 11 commits into from
Jun 12, 2019

Conversation

mattmcclean
Copy link
Contributor

@mattmcclean mattmcclean commented Jun 10, 2019

Have updated the package @aws-cdk/aws-stepfunctions-tasks to include support for SageMaker APIs as per documentation here: https://docs.aws.amazon.com/step-functions/latest/dg/connect-sagemaker.html

Includes support for the following Amazon SageMaker API calls:

  • CreateTrainingJob
  • CreateTransformJob

Partially remediates #1314


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@mattmcclean mattmcclean requested a review from a team as a code owner June 10, 2019 12:42
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, lots of work! Thanks!

Probably made a lot harder by the fact that we don't have SageMaker L2s yet (which also makes some points of the review moot).

Given that I have no experience with SageMaker, nor the time to learn about it right now, I'm inclined to just ship this as-is and let usage and review comments sort out how well it's working.

Can you please mark all new interfaces and classes with an

/**
 * @experimental
 */

In the docstrings?

@mattmcclean
Copy link
Contributor Author

Have marked all new interfaces and classes with @experimental

@rix0rrr rix0rrr merged commit 8b1f3ed into aws:master Jun 12, 2019
ScOut3R pushed a commit to ScOut3R/aws-cdk that referenced this pull request Jun 13, 2019
Have updated the package `@aws-cdk/aws-stepfunctions-tasks` to include support for SageMaker APIs as per documentation here: https://docs.aws.amazon.com/step-functions/latest/dg/connect-sagemaker.html

Includes support for the following Amazon SageMaker API calls:
* `CreateTrainingJob`
* `CreateTransformJob`

Partially remediates aws#1314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants