Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(events-targets): ecs:TagResource permission #28898

Merged
merged 10 commits into from
Mar 4, 2024
Merged

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Jan 27, 2024

I enabled the following:

aws ecs put-account-setting-default --name tagResourceAuthorization --value on

And then confirmed the task completes successfully.

Closes #28854.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Jan 27, 2024
@@ -0,0 +1,3 @@
FROM --platform=linux/amd64 public.ecr.aws/docker/library/python:3.12
ADD index.py .
CMD [ "python3", "./index.py" ]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this image needed to be changed. it was using a lambda image which resulted in the following:
entrypoint requires the handler name to be the first argument.

@msambol
Copy link
Contributor Author

msambol commented Feb 11, 2024

@ConnorRobertson Any feedback on this one?

Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @msambol, apologies for the delay to get around to this. The changes look good to me, just left one comment about accessing region.

Btw I just realized you're the one behind the Data structures and algorithms in X minutes videos, I'm a big fan!

packages/aws-cdk-lib/aws-events-targets/lib/ecs-task.ts Outdated Show resolved Hide resolved
@msambol
Copy link
Contributor Author

msambol commented Feb 29, 2024

Hi @msambol, apologies for the delay to get around to this. The changes look good to me, just left one comment about accessing region.

Btw I just realized you're the one behind the Data structures and algorithms in X minutes videos, I'm a big fan!

Thank you for the kind words! 😄 Much appreciated.

Good catch on cluster region. I updated the PR.

Copy link
Contributor

@aaythapa aaythapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @msambol, thanks for the code change (also a big fan 😁), just a small question but otherwise looks good.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 4, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cc90ed6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Mar 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4af0dfc into aws:main Mar 4, 2024
14 checks passed
mergify bot pushed a commit that referenced this pull request Mar 27, 2024
…#29633)

### Issue # (if applicable)

Closes #29610 

Related to #28898

### Reason for this change

Previously the AWS partition was hardcoded so it would not work for other special partitions.

### Description of changes

Replace hardcoded `aws` partition to be dynamically added with `this.cluster.stack.partition`. 

### Description of how you validated changes

Ran integ tests suite, no changes. 

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/medium Medium work item – several days of effort p1 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-events-targets): EcsTask target with tags does not get ecs:TagResource permission added to role
5 participants