Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(migrate): Add CDK Migrate --from-scan functionality #28962

Merged
merged 8 commits into from
Feb 2, 2024

Commits on Jan 26, 2024

  1. feat(migrate): Add template generator integration to CDK Migrate (#204)

    * initial jazz integration
    
    * cdk migrate with jazz integration
    
    * delete unused tests
    
    * move comment to appropriate test
    
    * refactor + comments to make it more readable
    
    * add filter ts doc
    
    * fix the test
    
    * Update packages/aws-cdk/lib/commands/migrate.ts
    
    Co-authored-by: Rico Hermans <rix0rrr@gmail.com>
    
    * Update packages/aws-cdk/lib/commands/migrate.ts
    
    Co-authored-by: Rico Hermans <rix0rrr@gmail.com>
    
    * Update packages/aws-cdk/lib/commands/migrate.ts
    
    Co-authored-by: Rico Hermans <rix0rrr@gmail.com>
    
    * Update packages/aws-cdk/lib/commands/migrate.ts
    
    Co-authored-by: Rico Hermans <rix0rrr@gmail.com>
    
    * Update packages/aws-cdk/lib/commands/migrate.ts
    
    Co-authored-by: Rico Hermans <rix0rrr@gmail.com>
    
    * minor refactors
    
    * make the progress bar safer
    
    * fix test
    
    * changes to managed flag pruning
    
    * Update packages/aws-cdk/lib/cdk-toolkit.ts
    
    Co-authored-by: Madeline Kusters <80541297+madeline-k@users.noreply.github.com>
    
    * Update packages/aws-cdk/lib/commands/migrate.ts
    
    Co-authored-by: Madeline Kusters <80541297+madeline-k@users.noreply.github.com>
    
    * Update packages/aws-cdk/lib/commands/migrate.ts
    
    Co-authored-by: Rico Hermans <rix0rrr@gmail.com>
    
    * Update packages/aws-cdk/lib/commands/migrate.ts
    
    Co-authored-by: Madeline Kusters <80541297+madeline-k@users.noreply.github.com>
    
    * Update packages/aws-cdk/lib/commands/migrate.ts
    
    Co-authored-by: Rico Hermans <rix0rrr@gmail.com>
    
    * resolve conflicts
    
    * or/and functionality
    
    * refactor user experience
    
    * display time since last scan
    
    * add user agent to cfn calls
    
    * make resources more statically typed
    
    * update and fix flitering
    
    * refactor template generator experience
    
    * refactor code
    
    * fix cli options
    
    * adjust apis to reflect template generator changes
    
    * update model
    
    * update tests
    
    * updated tests
    
    * fixes for migrate tests
    
    * fix generate template test mock
    
    * add failure test for most-recent
    
    * add filter failure test
    
    * feat(migrate): add migrate.json file creation to migrate workflow for imports (#212)
    
    * write file migrate.json to output
    
    * simplified source options
    
    * fixing tests
    
    * fix tests
    
    * fix test conflict and refactor tests
    
    * remove commented out test
    
    * add filter fail test
    
    * add default start test
    
    * add test for successful filters
    
    * remove duplicate test
    
    * update testing for import
    
    * Update packages/aws-cdk/lib/commands/migrate.ts
    
    Co-authored-by: Kendra Neil <53584728+TheRealAmazonKendra@users.noreply.github.com>
    
    * add test for migrate.json
    
    * add tests for migrate.json creation
    
    * remove dumb comment I put in
    
    ---------
    
    Co-authored-by: Hogan Bobertz <bobertzh@amazon.com>
    Co-authored-by: Kendra Neil <53584728+TheRealAmazonKendra@users.noreply.github.com>
    
    * readd comment
    
    * add additional tests and address feedback
    
    * update error message
    
    * update test to no longer clean up generated templates
    
    * comment out test for now
    
    * address feedback
    
    * address feedback and refactor
    
    * remove bangs
    
    ---------
    
    Co-authored-by: Hogan Bobertz <bobertzh@amazon.com>
    Co-authored-by: Rico Hermans <rix0rrr@gmail.com>
    Co-authored-by: Madeline Kusters <80541297+madeline-k@users.noreply.github.com>
    Co-authored-by: Kendra Neil <53584728+TheRealAmazonKendra@users.noreply.github.com>
    5 people committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    a86a710 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. chore: add readme generation into cdk migrate (#223)

    * add readme generation
    
    * update testing and add readme udpates
    
    * add test for readme generation
    
    * fix stupid bug I created
    
    * improve error message
    
    * uncomment tests
    
    * address feedback
    
    * update readme generation
    
    * update warnings:
    
    * update warnings:
    
    ---------
    
    Co-authored-by: Hogan Bobertz <bobertzh@amazon.com>
    HBobertz and Hogan Bobertz committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    a45e255 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. chore: fix cdk migrate not deleting templates and lack of deduplicati…

    …on (#228)
    
    * fix bugs
    
    * only create cfnTemplateGenerator if we need it
    
    * fix integ tests
    
    ---------
    
    Co-authored-by: Hogan Bobertz <bobertzh@amazon.com>
    HBobertz and Hogan Bobertz committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    3a8f926 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into cdk-migrate-release

    Hogan Bobertz committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    341f9a6 View commit details
    Browse the repository at this point in the history
  3. remove trim command that fails codebuild job

    Hogan Bobertz committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    4ec6ab5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    577159b View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. add extended timeout fixture

    Hogan Bobertz committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    fc3650c View commit details
    Browse the repository at this point in the history
  2. bug fix for cli integ tests

    Hogan Bobertz committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    b2af1e4 View commit details
    Browse the repository at this point in the history