Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(appconfig): compilation error in ts 4.2 and below because of using get in interface #29226

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

xazhao
Copy link
Contributor

@xazhao xazhao commented Feb 22, 2024

Reason for this change

There is a lint error which get syntax can't be used on interface before TS version 4.3

Description of changes

Replace get with a regular function.

Description of how you validated changes

Unit test passed.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Feb 22, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team February 22, 2024 21:09
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 22, 2024
@xazhao xazhao marked this pull request as ready for review February 22, 2024 21:11
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@xazhao
Copy link
Contributor Author

xazhao commented Feb 22, 2024

Exemption Request: fix the lint error. The current unit tests and integration test will cover this change.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Feb 22, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e00d073
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 22, 2024
@kaizencc kaizencc changed the title fix(appconfig): lint error because of using get in interface fix(appconfig): compilation error in ts 4.2 and below because of using get in interface Feb 22, 2024
@kaizencc kaizencc added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Feb 22, 2024
@kaizencc kaizencc changed the title fix(appconfig): compilation error in ts 4.2 and below because of using get in interface chore(appconfig): compilation error in ts 4.2 and below because of using get in interface Feb 22, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 22, 2024 21:39

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 22, 2024
Copy link
Contributor

mergify bot commented Feb 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit fcb7231 into aws:main Feb 22, 2024
43 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants