Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cognito): fix grammar in UserPool IDP docstrings #29255

Merged
merged 2 commits into from Feb 27, 2024

Conversation

douglasnaphas
Copy link
Contributor

Closes gh-29254.

Issue # (if applicable)

Closes #29254.

Reason for this change

This fixes minor grammar issues in docs.

Description of changes

I made no functional code changes, only changes to docs via comments. I made no design decisions.

Description of how you validated changes

Doc changes only.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the valued-contributor [Pilot] contributed between 6-12 PRs to the CDK label Feb 26, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team February 26, 2024 11:26
@github-actions github-actions bot added the p2 label Feb 26, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@kaizencc kaizencc changed the title Fix grammar in UserPool IDP docstrings chore(cognito): fix grammar in UserPool IDP docstrings Feb 26, 2024
kaizencc
kaizencc previously approved these changes Feb 26, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 26, 2024 15:15

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Feb 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

jfuss
jfuss previously approved these changes Feb 26, 2024
GavinZZ
GavinZZ previously approved these changes Feb 26, 2024
@mergify mergify bot dismissed stale reviews from GavinZZ, kaizencc, and jfuss February 26, 2024 22:37

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 275080e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 26, 2024
Copy link
Contributor

mergify bot commented Feb 27, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit cfd93b9 into aws:main Feb 27, 2024
16 checks passed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(cognito): Fix grammar in summaries of UserPool IDPs
5 participants