Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws-cloudwatch): allow up to 30 dimensions for metric #29323

Closed
wants to merge 2 commits into from
Closed

fix(aws-cloudwatch): allow up to 30 dimensions for metric #29323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a0bf7a
Changing dimension limit from 10 -> 30 for Metric
ruvimrd Feb 29, 2024
29d4f37
Changing dimension limit from 10 -> 30 for Metric
ruvimrd Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/aws-cdk-lib/aws-cloudwatch/lib/metric.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,8 +509,8 @@ export class Metric implements IMetric {
}

var dimsArray = Object.keys(dims);
if (dimsArray?.length > 10) {
throw new Error(`The maximum number of dimensions is 10, received ${dimsArray.length}`);
if (dimsArray?.length > 30) {
throw new Error(`The maximum number of dimensions is 30, received ${dimsArray.length}`);
}

dimsArray.map(key => {
Expand Down
48 changes: 44 additions & 4 deletions packages/aws-cdk-lib/aws-cloudwatch/test/metrics.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ describe('Metrics', () => {

});

testDeprecated('throws error when there are more than 10 dimensions', () => {
testDeprecated('throws error when there are more than 30 dimensions', () => {
expect(() => {
new Metric({
namespace: 'Test',
Expand All @@ -130,13 +130,33 @@ describe('Metrics', () => {
dimensionI: 'value9',
dimensionJ: 'value10',
dimensionK: 'value11',
dimensionL: 'value12',
dimensionM: 'value13',
dimensionN: 'value14',
dimensionO: 'value15',
dimensionP: 'value16',
dimensionQ: 'value17',
dimensionR: 'value18',
dimensionS: 'value19',
dimensionT: 'value20',
dimensionU: 'value21',
dimensionV: 'value22',
dimensionW: 'value23',
dimensionX: 'value24',
dimensionY: 'value25',
dimensionZ: 'value26',
dimensionAA: 'value27',
dimensionAB: 'value28',
dimensionAC: 'value29',
dimensionAD: 'value30',
dimensionAE: 'value31',
},
} );
}).toThrow(/The maximum number of dimensions is 10, received 11/);
}).toThrow(/The maximum number of dimensions is 30, received 31/);

});

test('throws error when there are more than 10 dimensions in dimensionsMap', () => {
test('throws error when there are more than 30 dimensions in dimensionsMap', () => {
expect(() => {
new Metric({
namespace: 'Test',
Expand All @@ -154,9 +174,29 @@ describe('Metrics', () => {
dimensionI: 'value9',
dimensionJ: 'value10',
dimensionK: 'value11',
dimensionL: 'value12',
dimensionM: 'value13',
dimensionN: 'value14',
dimensionO: 'value15',
dimensionP: 'value16',
dimensionQ: 'value17',
dimensionR: 'value18',
dimensionS: 'value19',
dimensionT: 'value20',
dimensionU: 'value21',
dimensionV: 'value22',
dimensionW: 'value23',
dimensionX: 'value24',
dimensionY: 'value25',
dimensionZ: 'value26',
dimensionAA: 'value27',
dimensionAB: 'value28',
dimensionAC: 'value29',
dimensionAD: 'value30',
dimensionAE: 'value31',
},
} );
}).toThrow(/The maximum number of dimensions is 10, received 11/);
}).toThrow(/The maximum number of dimensions is 30, received 31/);

});

Expand Down
Loading