Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(opensearchservice): change default value's description for multiAzWithStandbyEnabled #29634

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Mar 28, 2024

Reason for this change

Default value of the multiAzWithStandbyEnabled parameter will be set to true if the feature flag multiAzWithStandbyEnabled is enabled now.

However, the current description for the default value does not yet reflect that.

Description of changes

Change the description for the default value with the feature flag.

Description of how you validated changes

Nothing. It is just to change the description.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 labels Mar 28, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 28, 2024 06:09
@go-to-k
Copy link
Contributor Author

go-to-k commented Mar 28, 2024

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 01776ea
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 28, 2024
Copy link
Contributor

@vinayak-kukreja vinayak-kukreja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @go-to-k , thank you for your contribution. Really appreciate it. :)

Copy link
Contributor

mergify bot commented Mar 28, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit bb1981b into aws:main Mar 28, 2024
17 checks passed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 28, 2024
This was referenced Apr 1, 2024
@go-to-k go-to-k deleted the opensearch-feature-default-description branch June 28, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants