chore(step-function-tasks): add comment that aws-sdk integration pattern is not impacted by sdk upgrade
#29795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ern is not impacted by sdk upgrade Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
vinayak-kukreja
changed the title
aws-sdk integration pattern is not impacted by sdk upgrade
SankyRed
approved these changes
Apr 11, 2024
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
For upgrading sdkv2 to sdkv3, I have confirmed that the pattern used by step function task is not impacted by the migration and will remain the same.
Adding a comment to add historical context for anyone revisiting this package for another sdk upgrade.
Description of changes
Just added comments. No code changes.
Description of how you validated changes
No tests added for comments
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license