Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bedrock): support L1 Construct for Amazon Bedrock #29900

Closed
wants to merge 1 commit into from

Conversation

ymhiroki
Copy link
Contributor

@ymhiroki ymhiroki commented Apr 19, 2024

Issue # (if applicable)

Closes #29858

Reason for this change

L1 CloudFormation resource definitions are updated in v2.138.0 (#29798), however, the resources are not exported in the aws-bedrock module.
This change enables developers to use L1 Constructs for Amazon Bedrock.

Description of changes

I added an export statement for the aws-bedrock module.

Description of how you validated changes

This change doesn't contain any L2 construct updates.
I locally check the availability of L1 Constructs such as CfnKnowledgeBase, CfnAgent.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the valued-contributor [Pilot] contributed between 6-12 PRs to the CDK label Apr 19, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team April 19, 2024 08:45
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 labels Apr 19, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 425de6d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ymhiroki ymhiroki mentioned this pull request Apr 19, 2024
2 tasks
@aws-cdk-automation aws-cdk-automation added the pr/do-not-merge This PR should not be merged at this time. label Apr 19, 2024
@aws-cdk-automation
Copy link
Collaborator

The addition of a new module requires more than just this single export. We also need to make sure that new constructs don't conflict with what's been created manually here. I'm going to close this PR as I am currently working on this one as well.

@TheRealAmazonKendra
Copy link
Contributor

Oops. That comment above was me. I was working on fixing our automation at the same time as leaving some comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 pr/do-not-merge This PR should not be merged at this time. valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bedrock: add L1 constructs
3 participants