Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(diff): properties from ChangeSet diff were ignored #30268

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

fix(diff): properties from ChangeSet diff were ignored #30268

wants to merge 42 commits into from

Commits on May 18, 2024

  1. in progress

    @bergjaak
    bergjaak committed May 18, 2024
    Configuration menu
    Copy the full SHA
    b6d2cda View commit details
    Browse the repository at this point in the history

  2. in progress

    @bergjaak
    bergjaak committed May 18, 2024
    Configuration menu
    Copy the full SHA
    73e97bb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:aws/aws-cdk into bergjaak/ResourceD… 

    …iff2
    @bergjaak
    bergjaak committed May 18, 2024
    Configuration menu
    Copy the full SHA
    cd751b3 View commit details
    Browse the repository at this point in the history

  4. in progress

    @bergjaak
    bergjaak committed May 18, 2024
    Configuration menu
    Copy the full SHA
    c15b448 View commit details
    Browse the repository at this point in the history

  5. I am going to consider what happens if I just always replace resource… 

    …s from the template with what's in the changeset
    @bergjaak
    bergjaak committed May 18, 2024
    Configuration menu
    Copy the full SHA
    48c694c View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. get resource details from changeset

    @bergjaak
    bergjaak committed May 19, 2024
    Configuration menu
    Copy the full SHA
    62338a6 View commit details
    Browse the repository at this point in the history

  2. get resource details from changeset

    @bergjaak
    bergjaak committed May 19, 2024
    Configuration menu
    Copy the full SHA
    7a74592 View commit details
    Browse the repository at this point in the history

  3. get resource details from changeset

    @bergjaak
    bergjaak committed May 19, 2024
    Configuration menu
    Copy the full SHA
    0eba0cc View commit details
    Browse the repository at this point in the history

  4. update unit tests

    @bergjaak
    bergjaak committed May 19, 2024
    Configuration menu
    Copy the full SHA
    2e259b2 View commit details
    Browse the repository at this point in the history

  5. separate file for changeset tests

    @bergjaak
    bergjaak committed May 19, 2024
    Configuration menu
    Copy the full SHA
    464b699 View commit details
    Browse the repository at this point in the history

  6. integ test added and updated

    @bergjaak
    bergjaak committed May 19, 2024
    Configuration menu
    Copy the full SHA
    f8593d4 View commit details
    Browse the repository at this point in the history

  7. more tests

    @bergjaak
    bergjaak committed May 19, 2024
    Configuration menu
    Copy the full SHA
    05956d6 View commit details
    Browse the repository at this point in the history

  8. clean

    @bergjaak
    bergjaak committed May 19, 2024
    Configuration menu
    Copy the full SHA
    52129b0 View commit details
    Browse the repository at this point in the history

  9. tests are passing

    @bergjaak
    bergjaak committed May 19, 2024
    Configuration menu
    Copy the full SHA
    2683ed7 View commit details
    Browse the repository at this point in the history

  10. fully tested

    @bergjaak
    bergjaak committed May 19, 2024
    Configuration menu
    Copy the full SHA
    56e20d8 View commit details
    Browse the repository at this point in the history

  11. fully tested

    @bergjaak
    bergjaak committed May 19, 2024
    Configuration menu
    Copy the full SHA
    54a920e View commit details
    Browse the repository at this point in the history

  12. make _maybeParse better

    @bergjaak
    bergjaak committed May 19, 2024
    Configuration menu
    Copy the full SHA
    416f4b6 View commit details
    Browse the repository at this point in the history

  13. make _maybeParse better

    @bergjaak
    bergjaak committed May 19, 2024
    Configuration menu
    Copy the full SHA
    c15f9ef View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. rename describe

    @bergjaak
    bergjaak committed May 20, 2024
    Configuration menu
    Copy the full SHA
    bd9eccf View commit details
    Browse the repository at this point in the history

  2. clean

    @bergjaak
    bergjaak committed May 20, 2024
    Configuration menu
    Copy the full SHA
    3b986cb View commit details
    Browse the repository at this point in the history

  3. fix build

    @bergjaak
    bergjaak committed May 20, 2024
    Configuration menu
    Copy the full SHA
    fff90cc View commit details
    Browse the repository at this point in the history

  4. add test for formatting

    @bergjaak
    bergjaak committed May 20, 2024
    Configuration menu
    Copy the full SHA
    82c7a57 View commit details
    Browse the repository at this point in the history

  5. fix describe changeset

    @bergjaak
    bergjaak committed May 20, 2024
    Configuration menu
    Copy the full SHA
    207c416 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' of github.com:aws/aws-cdk into bergjaak/ResourceD… 

    …iff2
    @bergjaak
    bergjaak committed May 20, 2024
    Configuration menu
    Copy the full SHA
    0b29d2b View commit details
    Browse the repository at this point in the history

  7. better

    @bergjaak
    bergjaak committed May 20, 2024
    Configuration menu
    Copy the full SHA
    f12b22b View commit details
    Browse the repository at this point in the history

  8. add private and public

    @bergjaak
    bergjaak committed May 20, 2024
    Configuration menu
    Copy the full SHA
    3e38f56 View commit details
    Browse the repository at this point in the history

  9. use enum and better UNKNOWN

    @bergjaak
    bergjaak committed May 20, 2024
    Configuration menu
    Copy the full SHA
    9fcaadd View commit details
    Browse the repository at this point in the history

  10. include property values

    @bergjaak
    bergjaak committed May 20, 2024
    Configuration menu
    Copy the full SHA
    94cbbda View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. now use beforeContext and afterContext to see property changes

    @bergjaak
    bergjaak committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f23ce3d View commit details
    Browse the repository at this point in the history

  2. integ test for security changes

    @bergjaak
    bergjaak committed May 21, 2024
    Configuration menu
    Copy the full SHA
    61bbcce View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. fixing unit tests

    @bergjaak
    bergjaak committed May 22, 2024
    Configuration menu
    Copy the full SHA
    a06fc7b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:aws/aws-cdk into bergjaak/ResourceD… 

    …iff2
    @bergjaak
    bergjaak committed May 22, 2024
    Configuration menu
    Copy the full SHA
    c87aaa9 View commit details
    Browse the repository at this point in the history

  3. stuff

    @bergjaak
    bergjaak committed May 22, 2024
    Configuration menu
    Copy the full SHA
    6fcfafd View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. handle regions where describeChangeSet.IncludePropertyValues is not a… 

    …n option
    @bergjaak
    bergjaak committed May 23, 2024
    Configuration menu
    Copy the full SHA
    84ce20b View commit details
    Browse the repository at this point in the history

  2. clean up comments

    @bergjaak
    bergjaak committed May 23, 2024
    Configuration menu
    Copy the full SHA
    e65abf7 View commit details
    Browse the repository at this point in the history

  3. removed context backups

    @bergjaak
    bergjaak committed May 23, 2024
    Configuration menu
    Copy the full SHA
    f221971 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. ready

    @bergjaak
    bergjaak committed May 24, 2024
    Configuration menu
    Copy the full SHA
    213df93 View commit details
    Browse the repository at this point in the history

  2. ready

    @bergjaak
    bergjaak committed May 24, 2024
    Configuration menu
    Copy the full SHA
    357ff5e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into bergjaak/ResourceDiff2

    @bergjaak
    bergjaak committed May 24, 2024
    Configuration menu
    Copy the full SHA
    ed49a27 View commit details
    Browse the repository at this point in the history

  4. ready

    @bergjaak
    bergjaak committed May 24, 2024
    Configuration menu
    Copy the full SHA
    3694e71 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:aws/aws-cdk into bergjaak/ResourceD… 

    …iff2
    @bergjaak
    bergjaak committed May 24, 2024
    Configuration menu
    Copy the full SHA
    e1ff643 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'bergjaak/ResourceDiff2' of github.com:aws/aws-cdk into … 

    …bergjaak/ResourceDiff2
    @bergjaak
    bergjaak committed May 24, 2024
    Configuration menu
    Copy the full SHA
    8af1b4e View commit details
    Browse the repository at this point in the history