Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-cloudwatch): add support for labels on pie charts (aws#28929). #30284

Closed
wants to merge 1 commit into from

Conversation

kofrasa
Copy link

@kofrasa kofrasa commented May 21, 2024

Add a new "labels" property for graph widgets to show ratios for pie graphs.

Issue #28929

Closes #28929.

Reason for this change

When using a pie graph, the magnitude of ratios are not shown unless the { "labels": { "visible": true } } property is enabled.

Description of changes

The commits adds a new "labels" property with the structure LabelProps on the graph widget.
The structure contains a single nested boolean value "visible" which toggles the presence of the label on a pie graph. When set to true, CloudWatch dashboard will render the magnitude of ratios as percentages on the graph.
The README has been updated to reflect the new property and how it can be used.

Description of how you validated changes

The commit includes unit, integration, and snapshot tests as would be generated by the CDK library.
The change has also been manually verified from the CloudWatch console by enabling and disabling the property.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label May 21, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 21, 2024 01:49
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels May 21, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

Add a new "labels" property for graph widgets to show ratios for pie graphs.

Closes aws#28929
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ The title of the pull request should omit 'aws-' from the name of modified packages. Use 'cloudwatch' instead of 'aws-cloudwatch'.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e69dc59
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kofrasa kofrasa closed this May 21, 2024
Copy link
Contributor

mergify bot commented May 21, 2024

⚠️ The sha of the head commit of this PR conflicts with #30287. Mergify cannot evaluate rules on this PR. ⚠️

This was referenced May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(aws-cloudwatch): support labels on pie charts
2 participants