fix(opensearchservice): openSearchLogGroupResourcePolicy unnecessarily attempts to install latest sdk version

[victorchan314]

Issue #23113

Closes #23113 (Already closed, but looks like some changes were missed)
Related: #28688
Please let me know if the title needs to be changed. The title for the related pull request was approved, but the linter here indicates otherwise.

Reason for this change

If the flag is set to true, the custom resource has nondeterministic behavior, such as longer execution time and network access.

Description of changes

Explicitly set installLatestAwsSdk to false for OpenSearch and ElasticSearch's LogGroupResourcePolicies. No need to set it for AWS EventTargets's LogGroupResourcePolicy because they have a prop that allows the consumer to override it.

Description of how you validated changes

(Copied from #28688)
No tests add because the existing tests run with the @aws-cdk/customresources:installLatestAwsSdkDefault feature flag set to the recommended value. This change is merely change the OpenSearchAccessPolicy config for users that don't set the feature flag. We can safely do this, because we control the code for this custom resource and know it works with the provided SDK version.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 5ca8f38
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[xazhao]

Updated the title to include the full message

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[xazhao]

Looks good to me.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[TheRealAmazonKendra]

Adding do-not-merge on this because this custom resource is actually no longer necessary. The CloudFormation resource exists now. I'm preparing a change to remove it completely and to use the CloudFormation resource.

[TheRealAmazonKendra]

I've been working on this issue but the default is actually already false so adding it explicitly here will not make a difference anyway.