Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade jsii to ~5.4.21 #30518

Merged
merged 1 commit into from
Jun 11, 2024
Merged

chore: upgrade jsii to ~5.4.21 #30518

merged 1 commit into from
Jun 11, 2024

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Jun 11, 2024

Reason for this change

There was an upstream bug in jsii aws/jsii-compiler#1070 that caused the build to fail.
Updating the package manually to confirm the issue is resolved.

Description of changes

Upgraded to the latest version of jsii that includes a fix for the build issue.

Description of how you validated changes

Dependency upgrade. Existing tests cover this.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team June 11, 2024 11:16
@github-actions github-actions bot added the p2 label Jun 11, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 11, 2024
@mrgrain mrgrain changed the title chore: upgrade jsii to ~5.4.20 chore: upgrade jsii to ~5.4.21 Jun 11, 2024
@mrgrain mrgrain force-pushed the mrgrain/chore/upgrade/jsii branch from a93f948 to c713a84 Compare June 11, 2024 15:07
@mrgrain mrgrain marked this pull request as ready for review June 11, 2024 15:12
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 11, 2024
yarn.lock Outdated Show resolved Hide resolved
@mrgrain mrgrain changed the title chore: upgrade jsii to ~5.4.21 chore: upgrade jsii to ~5.4.21 Jun 11, 2024
@mrgrain mrgrain force-pushed the mrgrain/chore/upgrade/jsii branch from 8dae434 to f6c86e1 Compare June 11, 2024 17:32
@mrgrain mrgrain requested a review from paulhcsun June 11, 2024 17:32
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f6c86e1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@paulhcsun
Copy link
Contributor

@Mergifyio update

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 11, 2024
Copy link
Contributor

mergify bot commented Jun 11, 2024

update

☑️ Nothing to do

  • #commits-behind>0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position=-1 [📌 update requirement]

Copy link
Contributor

mergify bot commented Jun 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 634d67d into main Jun 11, 2024
17 checks passed
@mergify mergify bot deleted the mrgrain/chore/upgrade/jsii branch June 11, 2024 18:03
amazon-codecatalyst bot pushed a commit to pahud/aws-cdk that referenced this pull request Jun 12, 2024
### Reason for this change

There was an upstream bug in jsii aws/jsii-compiler#1070 that caused the build to fail.
Updating the package manually to confirm the issue is resolved.

### Description of changes

Upgraded to the latest version of jsii that includes a fix for the build issue.

### Description of how you validated changes

Dependency upgrade. Existing tests cover this.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mazyu36 pushed a commit to mazyu36/aws-cdk that referenced this pull request Jun 22, 2024
### Reason for this change

There was an upstream bug in jsii aws/jsii-compiler#1070 that caused the build to fail.
Updating the package manually to confirm the issue is resolved.

### Description of changes

Upgraded to the latest version of jsii that includes a fix for the build issue.

### Description of how you validated changes

Dependency upgrade. Existing tests cover this.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants