-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add service timeout to custom resources #30557
feat: add service timeout to custom resources #30557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
1a17df3
to
68ff606
Compare
If this is the way to go, please let me know if:
|
Hi @prazian, thanks for making contribution to CDK repo.
Feel free to reach out to me and tag me if you have any additional questions |
2ee78c2
to
10c5e09
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Issue # (if applicable)
Closes #30517.
Reason for this change
CloudFormation recently added the
ServiceTimeout
property to adjustable timeouts for custom resources:https://aws.amazon.com/about-aws/whats-new/2024/06/aws-cloudformation-dev-test-cycle-timeouts-custom-resources/
The Cfn documentation can be found here.
Currently, we have the timeout field for the lambda function that creates the resource (here is the cfn docs), but this new field sets timeout on a higher level (I guess).
Description of changes
Even though now it is possible to pass PascalCase properties, adding an explicit property would be more intuitive.
Description of how you validated changes
A new test called "custom timeout" has been added to check the availability of the ServiceTimeout property with the correct value.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license