fix(scheduler-targetes-alpha): multiple schedules cause resolution error during synth #30634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
valued-contributor
aws-cdk-automation
previously requested changes
Jun 24, 2024
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
Tietew
changed the title
Tietew
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
Tietew
force-pushed
the
scheduler-targets-fix-resolution-error
branch
from
6f9766a
to
f6004ff
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
Creating multiple
Schedules causes Resolution Error during synth.This PR does not fix the root cause (discussing at #28713), but apply a workaround to prevent the error.
Description of changes
Use
ServicePrincipalwith conditions directly, instead ofPrincipalWithConditions.Description of how you validated changes
Added a feature flag
{"@aws-cdk/aws-iam:minimizePolicies":true}to unit tests.Resolution errors occur before fix. No errors occur after fix.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license