feat(ecs-patterns): add containerCpu and containerMemoryLimitMiB property to ApplicationLoadBalancedFargateService

[ren-yamanashi]

Issue #20638

Closes #20638

Reason for this change

ApplicationLoadBalancedFargateService did not allow you to specify the CPU and memory of the container.

Description of changes

• Add containerCpu property to ApplicationLoadBalancedFargateServiceProps
• Add containerMemoryLimitMiB property to ApplicationLoadBalancedFargateServiceProps

Description of how you validated changes

Added both unit and integration tests.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[ren-yamanashi]

The current implementation adds containerCpu and containerMemoryLimitMiB to ApplicationLoadBalancedFargateServiceProps, would it be more appropriate to add them to FargateServiceBaseProps?

[go-to-k]

I am not sure, but I think the current implementation is good. Because putting it in FargateServiceBaseProps would be risky because it would affect all constructs that use all props that implement it.

Also, a property such as healthCheck, for example, could be included as a common item in the Base Construct, but right now it is only in the ApplicationLoadedBalancedFargateServiceProps (and QueueProcessingFargateServiceProps). From this point of view, it would make sense to include them only in the props.

(However, to be honest, I also think that cpu and memory are common properties for containers. But if it became necessary, it could be modified later.)

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 0ff6cdc
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[go-to-k]

Could you change the PR title from "feat(application-load-balanced-fargate-service): ..." to "feat(ecs-patterns): add containerCpu and containerMemoryLimitMiB property to ApplicationLoadBalancedFargateService"? Because we should specify the module name, not the construct name.

[ren-yamanashi]

@go-to-k

Could you change the PR title from "feat(application-load-balanced-fargate-service): ..." to "feat(ecs-patterns): add containerCpu and containerMemoryLimitMiB property to ApplicationLoadBalancedFargateService"? Because we should specify the module name, not the construct name.

Thank you for the suggestion. I have updated the PR title. Please check the changes at your convenience.

[go-to-k]

Thanks for this PR! I made some comments.

[go-to-k]

It seems that this test is included in the NetworkLoadBalancedFargateService test, so it needs to be moved somewhere within the ApplicationLoadBalancedFargateService test.

https://github.com/go-to-k/aws-cdk/blob/ffd9d9ce510a4c820b1437cce93c4772cd7c14c0/packages/aws-cdk-lib/aws-ecs-patterns/test/fargate/load-balanced-fargate-service.test.ts#L15

and nit.

Suggested change

	test('specify containerCpu And containerMemoryLimitMiB', () => {
	test('specify containerCpu and containerMemoryLimitMiB', () => {

[go-to-k]

I am not sure, but I think the current implementation is good. Because putting it in FargateServiceBaseProps would be risky because it would affect all constructs that use all props that implement it.

Also, a property such as healthCheck, for example, could be included as a common item in the Base Construct, but right now it is only in the ApplicationLoadedBalancedFargateServiceProps (and QueueProcessingFargateServiceProps). From this point of view, it would make sense to include them only in the props.

(However, to be honest, I also think that cpu and memory are common properties for containers. But if it became necessary, it could be modified later.)

[go-to-k]

Could you add the properties to the sample code above?

declare const cluster: ecs.Cluster;
const loadBalancedFargateService = new ecsPatterns.ApplicationLoadBalancedFargateService(this, 'Service', {
  cluster,
  memoryLimitMiB: 1024,
  cpu: 512,
  taskImageOptions: {
    // ...

[go-to-k]

Made some changes:

Suggested change

	If you specify the option `containerCpu` allows you to set the minimum number of CPU units to reserve for the container.
	If you specify the option `containerMemoryLimitMiB` allows you to set the amount of memory (in MiB) to provide to the container.
	To set the minimum number of CPU units to reserve for the container, you can use the `containerCpu` property.
	To set the amount of memory (in MiB) to provide to the container, you can use the `containerMemoryLimitMiB` property.