feat(amplify): Add resource support (wip) #3209

sthulb · 2019-07-05T08:36:18Z

Start of the Amplify CDK L2 construct

fixes issue: #3207

packages/@aws-cdk/aws-amplify/lib/app.ts

packages/@aws-cdk/aws-amplify/lib/branch.ts

packages/@aws-cdk/aws-amplify/package.json

sthulb · 2019-07-21T20:05:32Z

@eladb I think this is about done – mind reviewing it again?

eladb

Reviewed only app.ts but I believe many comments apply across the board. Let's do another iteration after you apply them throughout...

Also:

Missing README
All inline documentation is lacking. Preferably, copy & paste from the official AWS documentation with as much details as possible. Your goal is for people not to need to leave the IDE

packages/@aws-cdk/aws-amplify/package.json

packages/@aws-cdk/aws-amplify/lib/app.ts

jogold · 2019-07-29T07:45:06Z

Hey @sthulb, it would be nice to support the property AutoBranchCreation (Use the AutoBranchCreationConfig property type to automatically create branches that match a certain pattern., https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-amplify-app.html#cfn-amplify-app-autobranchcreationconfig) from the start.

(needs an update of the CFN specs).

AWS Amplify Console adds support for automatically deploying branches that match a specific pattern

sthulb · 2019-07-29T10:59:08Z

@jogold Indeed – I plan on supporting it in another PR. I want to get this one merged and then I'll start on the new features

eladb

inline docs are still lacking. Make sure all public APIs (incl. arguments) are fully documented.

eladb · 2019-07-29T13:10:57Z

packages/@aws-cdk/aws-amplify/README.md

-This module is part of the [AWS Cloud Development Kit](https://github.com/aws/aws-cdk) project.
+Define a new App:
+```ts
+new App(this, 'MyApp', {


use amplify.App. This is the idiomatic way we reference resources within construct library modules and also we want to disambiguate with core.App, which we idiomatically refer to as App.

eladb · 2019-07-29T13:11:30Z

packages/@aws-cdk/aws-amplify/README.md

@@ -15,8 +15,79 @@
 ---
 <!--END STABILITY BANNER-->



Provide some background about what is the Amplify service and what is this library capable of doing. As much as possible copy details and links from AWS documentation.

The Amplify service (known as the Amplify Console) offers continuous deployment and fully managed hosting for fullstack serverless web apps.

eladb · 2019-07-29T13:12:19Z

packages/@aws-cdk/aws-amplify/README.md

@@ -15,8 +15,79 @@
 ---
 <!--END STABILITY BANNER-->

-This module is part of the [AWS Cloud Development Kit](https://github.com/aws/aws-cdk) project.
+Define a new App:


Explain what an amplify app is. assume throughout this doc that people don't need to open 100 browser tabs to understand what they need to do. This should be as self-contained as possible.

An Amplify App is a collection of branches that represent frontend and backend environments.

jogold · 2019-08-01T07:44:19Z

@jogold Indeed – I plan on supporting it in another PR. I want to get this one merged and then I'll start on the new features

#3504

jogold · 2019-08-21T15:11:16Z

@sthulb is this still under development?

sthulb · 2019-08-21T16:36:31Z

Yep. I’m on holiday at the moment.

jogold · 2019-10-23T07:39:37Z

@sthulb is this still under development?

sthulb · 2019-10-23T11:56:40Z

sort of, it's on my to-do list of things.

mergify · 2019-11-01T19:42:35Z

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

PR title type(scope): text
- type: fix, feat, refactor go into CHANGELOG, chore is hidden
- scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
- text: use all lower-case, do not end with a period, do not include issue refs
PR Description
- Rationale: describe rationale of change and approach taken
- Issues: indicate issues fixed via: fixes #xxx or closes #xxx
- Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
Testing
- Unit test added. Prefer to add a new test rather than modify existing tests
- CLI or init templates change? Re-run/add CLI integration tests
Documentation
- README: update module README to describe new features
- API docs: public APIs must be documented. Copy from official AWS docs when possible
- Design: for significant features, follow design process

sthulb requested a review from a team as a code owner July 5, 2019 08:36

sthulb changed the title ~~feat: Amplify Console~~ wip: feat: Amplify Console Jul 5, 2019

sthulb changed the title ~~wip: feat: Amplify Console~~ feat(amplify): Add resource support (wip) Jul 10, 2019

eladb suggested changes Jul 10, 2019

View reviewed changes

sthulb requested a review from a team as a code owner July 21, 2019 09:12

eladb suggested changes Jul 22, 2019

View reviewed changes

sthulb mentioned this pull request Jul 25, 2019

CDK Support aws-amplify/amplify-hosting#7

Closed

sthulb added 22 commits July 26, 2019 16:18

start of amplify

fca16f4

Adds docstrings

4604403

adds default role

f5dac6f

remvoes unused ref

c7bc778

add tests

e2244bb

fix resource name

8106650

basic domain resource

a519b63

package json fixes

d87f93c

adds basic tests

7a8958d

domain tests

2a2fc85

adds test to verify addsubdomain

b8939d0

moved EnvVars and BasicAuth to shared file

bac81b0

improves domain interface

7d9e241

adds exclude for from-method rule

f91ba93

adds basic resolvers

df7587b

Start of branch resource

d3a001f

adds shared and branch resources

d004a4a

changes name of resource

8455f35

changes the name of the resource

01b46e6

adds more tests to ensure stability

5d573ed

adds a new method to bulk add env vars

42ddf95

removes junk import

f2a232d

sthulb added 14 commits July 26, 2019 16:20

adds extra doc strings

9ebd209

remove @example

0884725

moves arn references to built in funcs

a84e247

update branchName

4abfb0b

Use codebuilld's buildspec

8c7ea38

changes role behaviour

5f44d4d

updates packages

13f7091

removes old imports

80fe39f

removes resource prop

4a9871a

changes buildspec from string

49fca18

validates repository

d583247

adds @default

4d8c685

add readme details

844ca59

fixes issue – certificate isn't a certificate

39c8a0a

eladb reviewed Jul 29, 2019

View reviewed changes

adds a better example

9b6adaa

NGL321 assigned skinny85 Aug 1, 2019

skinny85 assigned shivlaks and unassigned skinny85 Aug 5, 2019

shivlaks added the large-review label Aug 9, 2019

NGL321 self-assigned this Oct 10, 2019

sthulb closed this Nov 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(amplify): Add resource support (wip) #3209

feat(amplify): Add resource support (wip) #3209

sthulb commented Jul 5, 2019 •

edited

sthulb commented Jul 21, 2019

eladb left a comment

jogold commented Jul 29, 2019 •

edited

sthulb commented Jul 29, 2019

eladb left a comment

eladb Jul 29, 2019

eladb Jul 29, 2019

swaminator Jul 30, 2019

eladb Jul 29, 2019

swaminator Jul 30, 2019

jogold commented Aug 1, 2019

jogold commented Aug 21, 2019

sthulb commented Aug 21, 2019

jogold commented Oct 23, 2019

sthulb commented Oct 23, 2019

mergify bot commented Nov 1, 2019

feat(amplify): Add resource support (wip) #3209

feat(amplify): Add resource support (wip) #3209

Conversation

sthulb commented Jul 5, 2019 • edited

sthulb commented Jul 21, 2019

eladb left a comment

Choose a reason for hiding this comment

jogold commented Jul 29, 2019 • edited

sthulb commented Jul 29, 2019

eladb left a comment

Choose a reason for hiding this comment

eladb Jul 29, 2019

Choose a reason for hiding this comment

eladb Jul 29, 2019

Choose a reason for hiding this comment

swaminator Jul 30, 2019

Choose a reason for hiding this comment

eladb Jul 29, 2019

Choose a reason for hiding this comment

swaminator Jul 30, 2019

Choose a reason for hiding this comment

jogold commented Aug 1, 2019

jogold commented Aug 21, 2019

sthulb commented Aug 21, 2019

jogold commented Oct 23, 2019

sthulb commented Oct 23, 2019

mergify bot commented Nov 1, 2019

sthulb commented Jul 5, 2019 •

edited

jogold commented Jul 29, 2019 •

edited