s3: bucketUrl and urlForObject(key) #370
Conversation
The `bucketUrl` returns the URL of the bucket and `urlForObject(key)` returns the URL of an object within the bucket. Furthermore: `iam.IIdentityResource` was soft-renamed to `iam.IPrincipal` (IIdentityResource is still supported).
| @@ -18,6 +18,12 @@ export class AwsDomainSuffix extends PseudoParameter { | |||
| } | |||
| } | |||
|
|
|||
| export class AwsURLSuffix extends PseudoParameter { | |||
| constructor() { | |||
| super('AWS::URLSuffix'); | |||
packages/@aws-cdk/s3/lib/bucket.ts
Outdated
| @@ -1,5 +1,5 @@ | |||
| import { applyRemovalPolicy, Arn, Construct, FnConcat, Output, PolicyStatement, RemovalPolicy, Token } from '@aws-cdk/core'; | |||
| import { IIdentityResource } from '@aws-cdk/iam'; | |||
| import { applyRemovalPolicy, Arn, AwsRegion, AwsURLSuffix, Construct, FnConcat, Output, PolicyStatement, RemovalPolicy, Token } from '@aws-cdk/core'; | |||
There was a problem hiding this comment.
Change to import * as foo from 'foo' style?
| * Similar to calling `urlForObject` with no object key. | ||
| */ | ||
| public get bucketUrl() { | ||
| return this.urlForObject(); |
There was a problem hiding this comment.
I would have expected the dependency to be in the reverse order of this...
Also, any reason to not use the DomainName attribute of AWS::S3::Bucket? Do we actually need to have a top-level S3 namespace rooted URL in some cases?
There was a problem hiding this comment.
Yes, in order for this to be available for BucketRefs, which don't have the DomainName information on them.
There was a problem hiding this comment.
The BucketRef could return the Fn::Concat stuff, and the Bucket could use the attribute directly. Isn't it?
There was a problem hiding this comment.
I would have expected the dependency to be in the reverse order of this...
This will result in FnConcat(FnConcat(...), key)) which is kind of ugly
There was a problem hiding this comment.
Only when using a BucketRef. But whatever, that is not crazy important.
The
bucketUrlreturns the URL of the bucketand
urlForObject(key)returns the URL of anobject within the bucket.
Furthermore:
iam.IIdentityResourcewas soft-renamedto
iam.IPrincipal(IIdentityResource isstill supported).
By submitting this pull request, I confirm that my contribution is made under
the terms of the beta license.