Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(alb): ALB requires region to use logging #5085

Merged
merged 4 commits into from
Dec 20, 2019
+4 −1
Merged

docs(alb): ALB requires region to use logging #5085

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b22f272
Add comment about requiring region to use logging
Nov 18, 2019
b13813e
Merge branch 'master' into Jerry-AWS-elb2-logging-region
Nov 25, 2019
1adead4
Update application-load-balancer.ts
rix0rrr Dec 20, 2019
b79fe4f
Merge branch 'master' into Jerry-AWS-elb2-logging-region
rix0rrr Dec 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/@aws-cdk/aws-elasticloadbalancingv2/lib/alb/application-load-balancer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,10 @@ export class ApplicationLoadBalancer extends BaseLoadBalancer implements IApplic
}

/**
* Enable access logging for this load balancer
* Enable access logging for this load balancer.
*
* A region must be specified on the stack containing the load balancer; you cannot enable logging on
* environment-agnostic stacks. See https://docs.aws.amazon.com/cdk/latest/guide/environments.html
*/
public logAccessLogs(bucket: s3.IBucket, prefix?: string) {
this.setAttribute('access_logs.s3.enabled', 'true');
Expand Down