Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stepfunctions): permission race condition on state machine deletion #5466

Merged
merged 6 commits into from
Dec 24, 2019
Merged

fix(stepfunctions): permission race condition on state machine deletion #5466

merged 6 commits into from
Dec 24, 2019
+69 −9

Conversation

mshober
Copy link
Contributor

@mshober mshober commented Dec 18, 2019

Lambda State Machines now depend on their policies
fixes #5336

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mshober mshober requested a review from eladb as a code owner December 18, 2019 01:18
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

rix0rrr
rix0rrr previously requested changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test and update the affected integ tests.

@mergify mergify bot dismissed rix0rrr’s stale review December 20, 2019 18:35

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr changed the title fix(stepfunctions): state machine should depend on its iam policies fix(stepfunctions): permission race condition on state machine deletion Dec 24, 2019
@rix0rrr rix0rrr merged commit c3ac965 into aws:master Dec 24, 2019
@mergify
Copy link
Contributor

mergify bot commented Dec 24, 2019

Thank you for contributing! Your pull request is now being automatically merged.

eladb pushed a commit that referenced this pull request Dec 24, 2019
@mshober
fix(stepfunctions): permission race condition on state machine deleti…
d2a45e7 
…on (#5466)

Lambda State Machines now depend on their policies.

Fixes #5336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

@eladb eladb Awaiting requested review from eladb

@garnaat garnaat Awaiting requested review from garnaat

@nija-at nija-at Awaiting requested review from nija-at

@RomainMuller RomainMuller Awaiting requested review from RomainMuller

@shivlaks shivlaks Awaiting requested review from shivlaks

@skinny85 skinny85 Awaiting requested review from skinny85

Assignees

@rix0rrr rix0rrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lambda State Machine should depend on its IAM Policies
3 participants
@mshober @aws-cdk-automation @rix0rrr