chore(build): resolve eslint plugins relative to cdk-build-tools #5528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugins are installed centrally under cdk-build-tools and therefore resolution should happen against that module instead of the current module. otherwise, we get an error `ESLint couldn't find the plugin "eslint-plugin-node".`
rix0rrr
approved these changes
Dec 23, 2019
| @@ -22,6 +22,7 @@ export async function compileCurrentPackage(timers: Timers, options: CDKBuildOpt | |||
| '.', | |||
| '--ext=.js,.ts', | |||
| '--ignore-path=.gitignore', | |||
| `--resolve-plugins-relative-to=${__dirname}`, | |||
There was a problem hiding this comment.
That'll only work "by luck" because everything is hoisted to the root. Most of the linters are, in fact, installed by dependency of cdk-build-tools and expected to resolve relative to there.
There was a problem hiding this comment.
__dirname is cdk-build-tools/lib which will resolve to the deps of cdk-build-tools, no?
There was a problem hiding this comment.
Oh I somehow though about it in the other way around. The actual problem at hand is caused (or maybe also caused) by missing --no-eslintrc here actually.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plugins are installed centrally under cdk-build-tools and therefore resolution should happen against that module instead of the current module. otherwise, we get an error
ESLint couldn't find the plugin "eslint-plugin-node".By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license