-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate aws-cdk from nodeunit to jest #5659
Merged
+2,714
−3,056
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,3 +29,6 @@ cdk.context.json | |
| .cdk.staging/ | ||
| cdk.out/ | ||
| *.tabl.json | ||
|
|
||
| # Yarn error log | ||
| yarn-error.log | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| import * as fs from 'fs-extra'; | ||
| import * as path from 'path'; | ||
| import { AccountAccessKeyCache } from '../lib/api/util/account-cache'; | ||
|
|
||
| async function makeCache() { | ||
| const dir = await fs.mkdtemp('/tmp/account-cache-test'); | ||
| const file = path.join(dir, 'cache.json'); | ||
| return { | ||
| cacheDir: dir, | ||
| cacheFile: file, | ||
| cache: new AccountAccessKeyCache(file), | ||
| }; | ||
| } | ||
|
|
||
| async function nukeCache(cacheDir: string) { | ||
| await fs.remove(cacheDir); | ||
| } | ||
|
|
||
| test('get(k) when cache is empty', async () => { | ||
| const { cacheDir, cacheFile, cache } = await makeCache(); | ||
| try { | ||
| expect(await cache.get('foo')).toBeUndefined(); | ||
| expect(await fs.pathExists(cacheFile)).toBeFalsy(); | ||
| } finally { | ||
| await nukeCache(cacheDir); | ||
| } | ||
| }); | ||
|
|
||
| test('put(k,v) and then get(k)', async () => { | ||
| const { cacheDir, cacheFile, cache } = await makeCache(); | ||
|
|
||
| try { | ||
| await cache.put('key', 'value'); | ||
| await cache.put('boo', 'bar'); | ||
| expect(await cache.get('key')).toBe('value'); | ||
|
|
||
| // create another cache instance on the same file, should still work | ||
| const cache2 = new AccountAccessKeyCache(cacheFile); | ||
| expect(await cache2.get('boo')).toBe('bar'); | ||
|
|
||
| // whitebox: read the file | ||
| expect(await fs.readJson(cacheFile)).toEqual({ | ||
| key: 'value', | ||
| boo: 'bar' | ||
| }); | ||
| } finally { | ||
| await nukeCache(cacheDir); | ||
| } | ||
| }); | ||
|
|
||
| test('fetch(k, resolver) can be used to "atomically" get + resolve + put', async () => { | ||
| const { cacheDir, cache } = await makeCache(); | ||
|
|
||
| try { | ||
| expect(await cache.get('foo')).toBeUndefined(); | ||
| expect(await cache.fetch('foo', async () => 'bar')).toBe('bar'); | ||
| expect(await cache.get('foo')).toBe('bar'); | ||
| } finally { | ||
| await nukeCache(cacheDir); | ||
| } | ||
| }); | ||
|
|
||
| test(`cache is nuked if it exceeds ${AccountAccessKeyCache.MAX_ENTRIES} entries`, async () => { | ||
| // This makes a lot of promises, so it can queue for a while... | ||
| jest.setTimeout(30_000); | ||
|
|
||
| const { cacheDir, cacheFile, cache } = await makeCache(); | ||
|
|
||
| try { | ||
| for (let i = 0; i < AccountAccessKeyCache.MAX_ENTRIES; ++i) { | ||
| await cache.put(`key${i}`, `value${i}`); | ||
| } | ||
|
|
||
| // verify all values are on disk | ||
| const otherCache = new AccountAccessKeyCache(cacheFile); | ||
| for (let i = 0; i < AccountAccessKeyCache.MAX_ENTRIES; ++i) { | ||
| expect(await otherCache.get(`key${i}`)).toBe(`value${i}`); | ||
| } | ||
|
|
||
| // add another value | ||
| await cache.put('nuke-me', 'genesis'); | ||
|
|
||
| // now, we expect only `nuke-me` to exist on disk | ||
| expect(await otherCache.get('nuke-me')).toBe('genesis'); | ||
| for (let i = 0; i < AccountAccessKeyCache.MAX_ENTRIES; ++i) { | ||
| expect(await otherCache.get(`key${i}`)).toBeUndefined(); | ||
| } | ||
| } finally { | ||
| await nukeCache(cacheDir); | ||
| } | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this duplicated configuration everywhere? For example the reporter types should be the same for all modules!