Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iam): immutable role cannot be used as a construct #6920

Merged
merged 3 commits into from
Mar 23, 2020
Merged

fix(iam): immutable role cannot be used as a construct #6920

merged 3 commits into from
Mar 23, 2020

Commits on Mar 21, 2020

  1. fix(dam): immutable role cannot be used as a construct 

    Due to a change in how `ConstructNode`s are associated with `Construct`s in 1.29.0, `ImmutableRole`'s "impersonation to a construct" -- by reflecting the construct's `node` property -- no longer works.

This change simply turns `ImmutableRole` into a real construct by extending the `Construct` base class.

This fixes the use case in #6885
    Elad Ben-Israel committed Mar 21, 2020
    Configuration menu
    Copy the full SHA
    7c9cb6d View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2020

  1. Merge branch 'master' into benisrae/fix/immutable-role-construct

    Elad Ben-Israel committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    b8e3da4 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. memoize immutable role so it can be called any number of times

    Elad Ben-Israel committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    9e08de8 View commit details
    Browse the repository at this point in the history