Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk-assets): context path not honored by Docker asset build #6957

Merged
merged 3 commits into from
Mar 24, 2020
Merged

fix(cdk-assets): context path not honored by Docker asset build #6957

merged 3 commits into from
Mar 24, 2020

Commits on Mar 24, 2020

  1. fix(cdk-assets): Docker Build Bad Context Path 

    Prior v1.29.0, the context passed to the docker build command was always
the current working directory. In v1.29.0, this was changed to be the
directory the user passed when instantiating the asset. However, docker
doesn't respect the context passed to the build command when the
`--file` argument is also passed. This broke assets for users passing
the `file` prop when constructing a `DockerImageAsset`.

This is fixed by changing the current working directory of the `docker build`
command and passing that context as '.'. Then docker uses the current working
directory as the context and correctly finds the image definition file from the
`file` prop. An existing integration test in the framework covers this case,
but does not fail unless the stack is deployed fresh since the asset isn't
rebuilt when the hash is not changed.

Fix: aws#6954 aws#6814
    @MrArnoldPalmer
    MrArnoldPalmer committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    70f984e View commit details
    Browse the repository at this point in the history

  2. Validate the correct cwd is passed to spawn where relevant

    @RomainMuller
    RomainMuller committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    eeeb8df View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix/docker-build-path

    @RomainMuller
    RomainMuller committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    3e67579 View commit details
    Browse the repository at this point in the history