feat(lambda-nodejs): use docker instead of npm for parcel-bundler

packages/@aws-cdk/aws-lambda-nodejs/README.md

@@ -19,14 +19,7 @@
 
 This library provides constructs for Node.js Lambda functions.
 
-To use this module, you will need to add a dependency on `parcel-bundler` in your
-`package.json`:
-
-```
-yarn add parcel-bundler@^1
-# or
-npm install parcel-bundler@^1
-```
+To use this module, you will need to have Docker installed.
 
 ### Node.js Function
 Define a `NodejsFunction`:

packages/@aws-cdk/aws-lambda-nodejs/lib/builder.ts

@@ -47,23 +47,7 @@ export interface BuilderOptions {
  * Builder
  */
 export class Builder {
-  private readonly parcelBinPath: string;
-
   constructor(private readonly options: BuilderOptions) {
-    let parcelPkgPath: string;
-    try {
-      parcelPkgPath = require.resolve('parcel-bundler/package.json'); // This will throw if `parcel-bundler` cannot be found
-    } catch (err) {
-      throw new Error('It looks like parcel-bundler is not installed. Please install v1.x of parcel-bundler with yarn or npm.');
-    }
-    const parcelDir = path.dirname(parcelPkgPath);
-    const parcelPkg = JSON.parse(fs.readFileSync(parcelPkgPath, 'utf8'));
-
-    if (!parcelPkg.version || !/^1\./.test(parcelPkg.version)) { // Peer dependency on parcel v1.x
-      throw new Error(`This module has a peer dependency on parcel-bundler v1.x. Got v${parcelPkg.version}.`);
-    }
-
-    this.parcelBinPath = path.join(parcelDir, parcelPkg.bin.parcel);
   }
 
   public build(): void {
@@ -78,29 +62,43 @@ export class Builder {
         });
       }
 
-      const args = [
-        'build', this.options.entry,
-        '--out-dir', this.options.outDir,
+      const dockerBuildArgs = [
+        "build", "-t", "parcel-bundler", path.join(__dirname, "../parcel-bundler")
+      ];
+      const dockerRunArgs = [
+        "run", "--rm",
+        "-v", `${path.dirname(path.resolve(this.options.entry))}:/entry`,
+        "-v", `${path.resolve(this.options.outDir)}:/out`,
+        ...(this.options.cacheDir ? ["-v", `${path.resolve(this.options.cacheDir)}:/cache`] : []),
+        "parcel-bundler"
+      ];
+      const parcelArgs = [
+        'parcel', 'build', `/entry/${path.basename(this.options.entry)}`,
+        '--out-dir', "/out",
         '--out-file', 'index.js',
         '--global', this.options.global,
         '--target', 'node',
         '--bundle-node-modules',
         '--log-level', '2',
         !this.options.minify && '--no-minify',
         !this.options.sourceMaps && '--no-source-maps',
-        ...this.options.cacheDir
-          ? ['--cache-dir', this.options.cacheDir]
-          : [],
+        ...(this.options.cacheDir ? ['--cache-dir', "/cache"] : []),
       ].filter(Boolean) as string[];
 
-      const parcel = spawnSync(this.parcelBinPath, args);
+      const build = spawnSync("docker", dockerBuildArgs);
+      if (build.error) {
+        throw build.error;
+      }
+      if (build.status !== 0) {
+        throw new Error(`[Status ${build.status}] stdout: ${build.stdout?.toString().trim()}\n\n\nstderr: ${build.stderr?.toString().trim()}`);
+      }
 
+      const parcel = spawnSync("docker", [...dockerRunArgs, ...parcelArgs]);
       if (parcel.error) {
         throw parcel.error;
       }
-
       if (parcel.status !== 0) {
-        throw new Error(parcel.stdout.toString().trim());
+        throw new Error(`[Status ${parcel.status}] stdout: ${parcel.stdout?.toString().trim()}\n\n\nstderr: ${parcel.stderr?.toString().trim()}`);
       }
     } catch (err) {
       throw new Error(`Failed to build file at ${this.options.entry}: ${err}`);

packages/@aws-cdk/aws-lambda-nodejs/package.json

@@ -88,7 +88,6 @@
     "cdk-build-tools": "0.0.0",
     "cdk-integ-tools": "0.0.0",
     "fs-extra": "^8.1.0",
-    "parcel-bundler": "^1.12.4",
     "pkglint": "0.0.0"
   },
   "dependencies": {

packages/@aws-cdk/aws-lambda-nodejs/parcel-bundler/Dockerfile

@@ -0,0 +1,5 @@
+FROM node:13.8.0-alpine3.11
+
+RUN yarn global add parcel-bundler@^1
+
+CMD [ "parcel" ]

packages/@aws-cdk/aws-lambda-nodejs/test/builder.test.ts

@@ -1,33 +1,22 @@
 import { spawnSync } from 'child_process';
-import * as fs from 'fs';
+import * as path from 'path';
 import { Builder } from '../lib/builder';
 
-let parcelPkgPath: string;
-let parcelPkg: Buffer;
-beforeAll(() => {
-  parcelPkgPath = require.resolve('parcel-bundler/package.json');
-  parcelPkg = fs.readFileSync(parcelPkgPath);
-});
-
-afterEach(() => {
-  fs.writeFileSync(parcelPkgPath, parcelPkg);
-});
-
 jest.mock('child_process', () => ({
   spawnSync: jest.fn((_cmd: string, args: string[]) => {
-    if (args[1] === 'error') {
+    if (args.includes('/entry/error')) {
       return { error: 'parcel-error' };
     }
 
-    if (args[1] === 'status') {
+    if (args.includes('/entry/status')) {
       return { status: 1, stdout: Buffer.from('status-error') };
     }
 
     return { error: null, status: 0 };
   })
 }));
 
-test('calls parcel with the correct args', () => {
+test('calls docker with the correct args', () => {
   const builder = new Builder({
     entry: 'entry',
     global: 'handler',
@@ -36,18 +25,29 @@ test('calls parcel with the correct args', () => {
   });
   builder.build();
 
-  expect(spawnSync).toHaveBeenCalledWith(expect.stringContaining('parcel-bundler'), expect.arrayContaining([
-    'build', 'entry',
-    '--out-dir', 'out-dir',
+  // docker build
+  expect(spawnSync).toHaveBeenNthCalledWith(1, 'docker', [
+    'build', '-t', 'parcel-bundler', path.join(__dirname, '../parcel-bundler')
+  ]);
+
+  // docker run
+  expect(spawnSync).toHaveBeenNthCalledWith(2, 'docker', [
+    'run', '--rm',
+    '-v', `${path.join(__dirname, '..')}:/entry`,
+    '-v', `${path.join(__dirname, '../out-dir')}:/out`,
+    '-v', `${path.join(__dirname, '../cache-dir')}:/cache`,
+    'parcel-bundler',
+    'parcel', 'build', '/entry/entry',
+    '--out-dir', '/out',
     '--out-file', 'index.js',
     '--global', 'handler',
     '--target', 'node',
     '--bundle-node-modules',
     '--log-level', '2',
     '--no-minify',
     '--no-source-maps',
-    '--cache-dir', 'cache-dir'
-  ]));
+    '--cache-dir', '/cache'
+  ]);
 });
 
 test('throws in case of error', () => {
@@ -67,15 +67,3 @@ test('throws if status is not 0', () => {
   });
   expect(() => builder.build()).toThrow('status-error');
 });
-
-test('throws when parcel-bundler is not 1.x', () => {
-  fs.writeFileSync(parcelPkgPath, JSON.stringify({
-    ...JSON.parse(parcelPkg.toString()),
-    version: '2.3.4'
-  }));
-  expect(() => new Builder({
-    entry: 'entry',
-    global: 'handler',
-    outDir: 'out-dur'
-  })).toThrow(/This module has a peer dependency on parcel-bundler v1.x. Got v2.3.4./);
-});

packages/@aws-cdk/aws-lambda-nodejs/test/integ.function.expected.json

@@ -36,7 +36,7 @@
       "Properties": {
         "Code": {
           "S3Bucket": {
-            "Ref": "AssetParametersa736580e4382e6d67a7acaedbbd271f559ed918382808ae1431364ae70286543S3BucketD096DC83"
+            "Ref": "AssetParametersfdefbd5f0d90231e11e34991218a3674ec3ac1a3a99948038164c6d7a8efa88eS3Bucket9E60CFAE"
           },
           "S3Key": {
             "Fn::Join": [
@@ -49,7 +49,7 @@
                       "Fn::Split": [
                         "||",
                         {
-                          "Ref": "AssetParametersa736580e4382e6d67a7acaedbbd271f559ed918382808ae1431364ae70286543S3VersionKeyA76287A5"
+                          "Ref": "AssetParametersfdefbd5f0d90231e11e34991218a3674ec3ac1a3a99948038164c6d7a8efa88eS3VersionKey74429E96"
                         }
                       ]
                     }
@@ -62,7 +62,7 @@
                       "Fn::Split": [
                         "||",
                         {
-                          "Ref": "AssetParametersa736580e4382e6d67a7acaedbbd271f559ed918382808ae1431364ae70286543S3VersionKeyA76287A5"
+                          "Ref": "AssetParametersfdefbd5f0d90231e11e34991218a3674ec3ac1a3a99948038164c6d7a8efa88eS3VersionKey74429E96"
                         }
                       ]
                     }
@@ -172,17 +172,17 @@
     }
   },
   "Parameters": {
-    "AssetParametersa736580e4382e6d67a7acaedbbd271f559ed918382808ae1431364ae70286543S3BucketD096DC83": {
+    "AssetParametersfdefbd5f0d90231e11e34991218a3674ec3ac1a3a99948038164c6d7a8efa88eS3Bucket9E60CFAE": {
       "Type": "String",
-      "Description": "S3 bucket for asset \"a736580e4382e6d67a7acaedbbd271f559ed918382808ae1431364ae70286543\""
+      "Description": "S3 bucket for asset \"fdefbd5f0d90231e11e34991218a3674ec3ac1a3a99948038164c6d7a8efa88e\""
     },
-    "AssetParametersa736580e4382e6d67a7acaedbbd271f559ed918382808ae1431364ae70286543S3VersionKeyA76287A5": {
+    "AssetParametersfdefbd5f0d90231e11e34991218a3674ec3ac1a3a99948038164c6d7a8efa88eS3VersionKey74429E96": {
       "Type": "String",
-      "Description": "S3 key for asset version \"a736580e4382e6d67a7acaedbbd271f559ed918382808ae1431364ae70286543\""
+      "Description": "S3 key for asset version \"fdefbd5f0d90231e11e34991218a3674ec3ac1a3a99948038164c6d7a8efa88e\""
     },
-    "AssetParametersa736580e4382e6d67a7acaedbbd271f559ed918382808ae1431364ae70286543ArtifactHashB7337532": {
+    "AssetParametersfdefbd5f0d90231e11e34991218a3674ec3ac1a3a99948038164c6d7a8efa88eArtifactHashAA5D4787": {
       "Type": "String",
-      "Description": "Artifact hash for asset \"a736580e4382e6d67a7acaedbbd271f559ed918382808ae1431364ae70286543\""
+      "Description": "Artifact hash for asset \"fdefbd5f0d90231e11e34991218a3674ec3ac1a3a99948038164c6d7a8efa88e\""
     },
     "AssetParameters0d445d366e339b4344917ba638a4cb2dcddfd0e063b10fb909340fd1cc51c278S3BucketDBD288E6": {
       "Type": "String",