Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws-s3): remove policy argument #730

Merged
merged 1 commit into from Sep 17, 2018
Merged

fix(aws-s3): remove policy argument #730

merged 1 commit into from Sep 17, 2018

Commits on Sep 17, 2018

  1. fix(aws-s3): remove policy argument 

    This argument served as a red herring, and made it harder
for people to find the correct method of setting a bucket
policy, by calling `addToPolicy()`.

The provided method of providing an existing Policy object on object
creation cannot actually work, because a `BucketPolicy` object requires
the `Bucket` instance as a constructor argument, which means the
`Bucket` object cannot take a `BucketPolicy` in its constructor.

Fixes #672.
    Rico Huijbers committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    154560c View commit details
    Browse the repository at this point in the history