chore(design): fix variable type in example #8358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change `fooboo`'s type from `string` to `string[]`. `fooboo` is string array in this example.
HaileyGu
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
ncaq
added a commit
to ncaq/aws-cdk
that referenced
this pull request
Oct 15, 2020
aws-lambda-nodejs have issue * [npm install -g yarn · Issue #6 · nodejs/corepack](nodejs/corepack#6) * [npm install yarn --global fails in docker container · Issue aws#8358 · yarnpkg/yarn](yarnpkg/yarn#8358) From issue comment, > For future reference, you can (should) pin your version rather than use whatever the latest is on npm (by using yarn@1.22.6, etc) - it's a good practice anyway regardless of the conditions, as you never know which bug could slip by us. You can also use the yarn-path setting to ensure that upgrades go through the appropriate review processes (including CI). > > <yarnpkg/yarn#8358 (comment)> So we'll follow it. And from issue comment, > Fwiw we don't plan to add any more features to Yarn 1, as all of our resources have shifted to Yarn 2. The past few commits have been aimed toward making the transition a bit easier, in particular thanks to the Corepack initiative which we hope will make it easier to use Yarn (both 1 & 2) by removing the need to manually install them. > > <yarnpkg/yarn#8358 (comment)> There's not much need to be concerned with the latest version of 1.
mergify bot
pushed a commit
that referenced
this pull request
Oct 21, 2020
fixes #10881 # fix from sh to bash `lib/bundlers.ts` actually uses not `sh` but `bash`, `bash` is a good way to test. # lock yarn version aws-lambda-nodejs have issue * [npm install -g yarn · Issue #6 · nodejs/corepack](nodejs/corepack#6) * [npm install yarn --global fails in docker container · Issue #8358 · yarnpkg/yarn](yarnpkg/yarn#8358) From issue comment, > For future reference, you can (should) pin your version rather than use whatever the latest is on npm (by using yarn@1.22.6, etc) - it's a good practice anyway regardless of the conditions, as you never know which bug could slip by us. You can also use the yarn-path setting to ensure that upgrades go through the appropriate review processes (including CI). > > <yarnpkg/yarn#8358 (comment)> So we'll follow it. And from issue comment, > Fwiw we don't plan to add any more features to Yarn 1, as all of our resources have shifted to Yarn 2. The past few commits have been aimed toward making the transition a bit easier, in particular thanks to the Corepack initiative which we hope will make it easier to use Yarn (both 1 & 2) by removing the need to manually install them. > > <yarnpkg/yarn#8358 (comment)> There's not much need to be concerned with the latest version of 1. # allow execute command for non root user `amazon/aws-sam-cli-build-image-nodejs12.x` don't have user that index is 1000. So create non root user. `/` in `amazon/aws-sam-cli-build-image-nodejs12.x` permission is `700`. change to allow execute command for non root user. I really don't want to change around the permissions, but I don't have a choice. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change
fooboo's type fromstringtostring[].fooboois string array in this example.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license