Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lambda-nodejs): use bundling from core #8576

Merged
merged 4 commits into from Jun 17, 2020

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Jun 16, 2020

Refactor to use bundling from core.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Refactor to use bundling from `core`.
@jogold
Copy link
Contributor Author

jogold commented Jun 16, 2020

@eladb at this stage it is only a "clean up" of the actual code.

It should evolve in a second stage to an API with static methods for the different types of bundling/building of Node.js functions? What do you think? Something like fromParcel() (the current implementation), fromInstall() (runs npm install in a self contained Lambda directory inside the right runtime docker image), ...

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 064e029
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb previously requested changes Jun 16, 2020
packages/@aws-cdk/aws-lambda-nodejs/lib/function.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda-nodejs/lib/parcel-code.ts Outdated Show resolved Hide resolved
Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
@mergify mergify bot dismissed eladb’s stale review June 16, 2020 17:41

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: fdd5d47
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d610385
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb previously approved these changes Jun 17, 2020
@mergify mergify bot dismissed eladb’s stale review June 17, 2020 10:46

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 10de54d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 17, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5491922 into aws:master Jun 17, 2020
@jogold jogold deleted the lambda-nodejs-core-bundling branch June 18, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants