aws cloudformation package generates invalid TemplateURL

[jkit]

Description

The aws cloudformation package replaces local paths with an s3:// URL, however, nested stacks in a CloudFormation template require that the TemplateURL is specified as a https://s3.amazonaws.com/... URL.

Environment

aws --version
aws-cli/1.11.27 Python/2.7.10 Darwin/16.1.0 botocore/1.4.84

Repro Steps

1. Create A Simple Stack

# simple-bucket.yml
Resources:
  SimpleBucket:
    Properties:
      AccessControl: Private
      BucketName: some-bucket
    Type: AWS::S3::Bucket

2. Create A Stack With a Nested Stack

# nested-bucket.yml
Resources:
  NestedBucket:
    Type: "AWS::CloudFormation::Stack"
    Properties:
      TemplateURL: simple-bucket.yml

3. Generate New Template with aws cloudformation package

aws cloudformation package \
  --template-file nested-bucket.yml \
  --s3-bucket templates \
  --output-template-file package-template.yml

This generates package-template.yml:

Resources:
  NestedBucket:
    Properties:
      TemplateURL: s3://templates/2605eb3b081bda5a3e38952c8e4b70a4.template
    Type: AWS::CloudFormation::Stack

4. Deploy Generated Template

aws cloudformation deploy \
  --template-file package-template.yml \
  --stack-name TestStack

This fails with:

The specified url must be an Amazon S3 URL.

Workaround

If I change TemplateURL from s3://templates/2605eb3b081bda5a3e38952c8e4b70a4.template to https://s3.amazonaws.com/templates/f8b1a0b3844e6eea8ff045565f5b0b7e.template and rerun the deploy command. It works fine.

[djamison]

@jkit's workaround worked for me.

[kyleknap]

I can confirm this issue. We are working on a fix.

[jamesls]

Should be fixed via #2360