Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in CodeArtifact tool flags to modify login behaviour #6634

Open
whardier opened this issue Dec 31, 2021 · 5 comments · May be fixed by #6633
Open

Add in CodeArtifact tool flags to modify login behaviour #6634

whardier opened this issue Dec 31, 2021 · 5 comments · May be fixed by #6633
Labels
codeartifact login customization Issues related to CLI customizations (located in /awscli/customizations) feature-request A feature should be added or improved. p3 This is a minor priority issue

Comments

@whardier
Copy link

whardier commented Dec 31, 2021

Is your feature request related to a problem? Please describe.
Pip and other CodeArtifact login tools need to modify login behaviour through the use of flags. Immediate use case is to alter which configuration setting is used with pip tool in order to avoid pulling through codeartifact upstreams (they are problematic) as well as speed up installation process (codeartifact is also slow)

Describe the solution you'd like
I've provided PR #6633 to best describe the solution. Allow for --flags and provide some fairly generic choices.

Describe alternatives you've considered
using --dry-run and sed to alter the command.. this is not a secure approach.

Additional context
Let's speed up build/deploy and make devs lives a smidge easier when utilizing CodeArtifact.

@whardier whardier added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 31, 2021
@kdaily kdaily self-assigned this Jan 3, 2022
@kdaily kdaily removed the needs-triage This issue or PR still needs to be triaged. label Jan 3, 2022
@kdaily
Copy link
Member

kdaily commented Jan 3, 2022

Hi @whardier,

Thanks for your post and the pull request. The CodeArtifact commands for the AWS CLI are maintained by the CodeArtifact team. I'll let them know about this suggestion. I'm not familiar with how this command works. Having an example of what you do now (with --dry-run and sed) and how your proposed change works to solve this would be helpful.

I can't provide a timeframe when the CodeArtifact team will be able to review, but I'll update when I hear something.

@kdaily kdaily added codeartifact login customization Issues related to CLI customizations (located in /awscli/customizations) needs-review This issue or pull request needs review from a core team member. labels Jan 3, 2022
@kdaily kdaily added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jan 3, 2022
@github-actions
Copy link

github-actions bot commented Jan 8, 2022

Greetings! It looks like this issue hasn’t been active in longer than five days. We encourage you to check if this is still an issue in the latest release. In the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment or upvote with a reaction on the initial post to prevent automatic closure. If the issue is already closed, please feel free to open a new one.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jan 8, 2022
@whardier
Copy link
Author

Hmm. The close out process seems sub-optimal.

@stealthycoin
Copy link
Contributor

Yea sorry about that. I'm going to re-open it. We have a new process for prioritizing contributions to review #6828 detailing improvements to the contributing process. So I will be re-opening the issue for tracking interest, and marking the PR as draft until the criteria in the new process is met.

@stealthycoin stealthycoin reopened this Apr 19, 2022
@stealthycoin stealthycoin removed response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. closed-for-staleness labels Apr 19, 2022
@tim-finnigan tim-finnigan added the p2 This is a standard priority issue label Nov 9, 2022
@tim-finnigan
Copy link
Contributor

Thanks for your patience, it looks like this fell off of our radar. I'll try reaching out to the CodeArtifact team again to review this and share their feedback.

@tim-finnigan tim-finnigan added p3 This is a minor priority issue and removed needs-review This issue or pull request needs review from a core team member. p2 This is a standard priority issue labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codeartifact login customization Issues related to CLI customizations (located in /awscli/customizations) feature-request A feature should be added or improved. p3 This is a minor priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants