Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in flags argument for codeartifact login and alter pip tool to ho… #6633

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

whardier
Copy link

@whardier whardier commented Dec 31, 2021

Submitting this in advance of writing tests. Providing a patch and looking for feedback.

This patch adds in flags argument for codeartifact login and alter pip tool to honor the secondary flag.

Issue #, if available:
#6634

Description of changes:

Offer a compatible feature update to codeartifact login that allows for flags to be associated with a tool. This allows for tools to alter how login is handled.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kdaily kdaily added codeartifact login customization Issues related to CLI customizations (located in /awscli/customizations) labels Jan 3, 2022
@kdaily kdaily linked an issue Jan 3, 2022 that may be closed by this pull request
@stealthycoin stealthycoin marked this pull request as draft April 19, 2022 20:46
@stealthycoin
Copy link
Contributor

Our team just put out a recent proposal in #6828 detailing improvements to the contribution process. I updated the issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codeartifact login community customization Issues related to CLI customizations (located in /awscli/customizations)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add in CodeArtifact tool flags to modify login behaviour
4 participants