Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce #614, fix for urlencoding source param in s3 copy #688

Merged
merged 5 commits into from
Mar 5, 2014

Conversation

jamesls
Copy link
Member

@jamesls jamesls commented Mar 4, 2014

This adds on #614. The issue was that we need to move all of the encoding/urlencoding into botocore. This means that the CLI should not be utf-8 encoding the source param, otherwise we double encoding the param. This is what originally caused the unicode test regressions.

Verified that unicode/+ chars can properly be copied to from S3 buckets.

@toastdriven
Copy link
Contributor

:shipit:

@jamesls jamesls merged commit 68cc044 into aws:develop Mar 5, 2014
@jamesls jamesls deleted the garnaat-fix-614 branch June 23, 2014 18:23
thoward-godaddy pushed a commit to thoward-godaddy/aws-cli that referenced this pull request Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants