copy permission bits when single file defined in CodeUri #3112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CodeUri:` is set to a file (eg. golang compiled file), the file permissions are not copied across when packaged using `aws cloudformation package` and `aws cloudformation deploy`. The packaged file has these permission `-rw-r--r--`. I get the following error when test the lambda function.
`{ "errorMessage": "fork/exec /var/task/main: permission denied", "errorType": "PathError" }`
`shutil.copyfile` doesn't copy the file permission bits, however `shutil.copy` copies the permission bits.
…copy-with-permission copy permission bits when single file defined in CodeUri
|
Changed test |
Codecov Report
@@ Coverage Diff @@
## develop #3112 +/- ##
===========================================
- Coverage 95.93% 95.92% -0.01%
===========================================
Files 166 166
Lines 12616 12616
===========================================
- Hits 12103 12102 -1
- Misses 513 514 +1
Continue to review full report at Codecov.
|
|
+1 for this fix. Would be nice to merge this PR - it solves my problem. |
emilyrohrbough
approved these changes
Mar 1, 2021
kdaily
added
cloudformation package-deploy
customization
|
V326758308 |
moelasmar
approved these changes
Mar 22, 2021
Merged
|
Merged in #6034 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeUri:is set to a file (eg. golang compiled file), the file permissions are not copied across when packaged usingaws cloudformation packageandaws cloudformation deploy. The packaged file has these permission-rw-r--r--. I get the following error when test the lambda function.{ "errorMessage": "fork/exec /var/task/main: permission denied", "errorType": "PathError" }shutil.copyfiledoesn't copy the file permission bits, howevershutil.copycopies the permission bits. The original file permission isrwxr-xr-x.