Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support export ModulePackage in AWS::CloudFormation::ModuleVersion #6044

Conversation

alexisfacques
Copy link

Issue #, if available:
#6043

Description of changes:
AWS CloudFormation released registry modules, that can be created from a CloudFormation Template, and include a ModulePackage property, similar to AWS::Serverless::Function's CodeUri et. al.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Mar 27, 2021

Codecov Report

Merging #6044 (77fc386) into develop (83b4378) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6044   +/-   ##
========================================
  Coverage    92.66%   92.66%           
========================================
  Files          204      204           
  Lines        16188    16192    +4     
========================================
+ Hits         15000    15004    +4     
  Misses        1188     1188           
Impacted Files Coverage Δ
...customizations/cloudformation/artifact_exporter.py 98.67% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83b4378...77fc386. Read the comment docs.

@alexisfacques alexisfacques force-pushed the support-cfn-module-version-aws-package branch from cc5c741 to 4d2a0c3 Compare March 27, 2021 14:21
@stealthycoin
Copy link
Contributor

stealthycoin commented Apr 25, 2022

Hi @alexisfacques thanks for the PR. Our team just put out a recent proposal in #6828 detailing improvements to the contribution process. We are working through open PRs and have determined this PR to be in the ready-for-review stage (described here).

We are tracking this PR here on our project board and it can be set to to the review stage once new changes are ready to be reviewed.

@tim-finnigan
Copy link
Contributor

Thanks again for the PR - I brought this up for discussion with the team, and these changes are currently not under consideration - but you can refer to the SAM CLI if you need to use AWS::CloudFormation::ModuleVersion: https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/deploy-upload-local-files.html#deploy-upload-local-files-use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for 'AWS::CloudFormation::ModuleVersion' resource to 'aws cloudformation package' command
4 participants